Linear issue:
https://linear.app/comm/issue/ENG-1357/rename-sidebar-to-thread-in-product-copy
Diff renames thread to chat in all strings displayed to the user in web
Details
Details
- Reviewers
tomek ashoat • jacek • abosh - Commits
- rCOMM4c883c8ccb46: [web] Rename thread to chat
Checked if strings changed as expected in web.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Branch
- inka/thread-rename
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| web/modals/threads/confirm-leave-thread-modal.react.js | ||
|---|---|---|
| 39 | Should this be capitalized to match the capitalized "t" in the old version of the code? In my opinion, the lowercase 'chat' looks nicer but wanted to confirm.  | |
| web/chat/thread-menu.react.js | ||
|---|---|---|
| 217 |
| |
| web/modals/chat/sidebar-promote-modal.react.js | ||
| 29 | Same comment as above – consider "Promote to channel" for consistency with native | |
| 35 | Let's say "Promoting a sidebar to a channel cannot be undone." (I assume sidebar -> thread will be handled in a separate diff) | |
| 41 | Same comment as above – consider "Promote to channel" for consistency with native | |
| web/modals/threads/confirm-leave-thread-modal.react.js | ||
| 39 | I agree that lowercase is better here | |
| web/modals/threads/subchannels/subchannels-modal.react.js | ||
| 116 | Let's say "channel" instead of "chat", since subchannels can only exist inside another channel (or community, which we can consider a special kind of channel) | |
| web/chat/thread-menu.react.js | ||
|---|---|---|
| 217 | What should I do about the upper- and lowercase?  We will then have the following buttons next to each other: "Promote to channel" "Leave Chat" Since we're also changing "Yes, leave Chat" to "Yes, leave channel" maybe all buttons should have that casing convention? | |
| web/modals/chat/sidebar-promote-modal.react.js | ||
| 35 | Yes, I will be making separate diffs for sidebar -> thread renaming. | |
Comment Actions
This looks great!!
Separately, one note regarding the whole diff stack – even though there might not be a formal dependency relationship, it would make reviewing a little easier if the related diffs (D4536, D4538, and this one) were put in a diff stack. More details about that workflow here.
A good rule of thumb is that if you have multiple commits in a branch, then you should have multiple diffs in a stack. In this case it's probably a good idea to have these commits in the same branch, so it's probably a good idea to have these diffs in a stack.
| web/chat/thread-menu.react.js | ||
|---|---|---|
| 217 | Good question!! Thanks for catching this. I agree it would be good to be consistent. Can you submit a separate diff to change "Leave Chat" to "Leave chat"? | |
| web/chat/thread-menu.react.js | ||
|---|---|---|
| 217 | Sure, done! | |