Page MenuHomePhabricator

[services] Backup - pull backup - change logic to use att holders out of data section
ClosedPublic

Authored by karol on Jul 18 2022, 7:00 AM.
Tags
None
Referenced Files
F3399523: D4555.id14859.diff
Mon, Dec 2, 3:32 AM
Unknown Object (File)
Sun, Nov 24, 7:01 PM
Unknown Object (File)
Sun, Nov 10, 10:05 PM
Unknown Object (File)
Sun, Nov 10, 2:13 PM
Unknown Object (File)
Sat, Nov 9, 2:33 PM
Unknown Object (File)
Sat, Nov 9, 1:46 PM
Unknown Object (File)
Sat, Nov 9, 12:42 PM
Unknown Object (File)
Sat, Nov 9, 12:02 PM

Details

Summary

Depends on D4571

Make pull backup reactor works properly for "extra data" - more context in D4439. With this, we can work with the attachments as well.

Test Plan

full test plan in D4556, for now, the service builds

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

karol edited the summary of this revision. (Show Details)
karol edited the test plan for this revision. (Show Details)

rebase

tomek requested changes to this revision.Jul 21 2022, 3:07 AM
tomek added inline comments.
services/backup/src/Reactors/server/PullBackupReactor.cpp
87–90 ↗(On Diff #14618)

Are you sure this return should be conditional? Also, setting state to LOGS should be the last operation, just before the return.

This revision now requires changes to proceed.Jul 21 2022, 3:07 AM
karol added inline comments.
services/backup/src/Reactors/server/PullBackupReactor.cpp
87–90 ↗(On Diff #14618)

I think so.

  • If there's something in the internal buffer in the end, we want to send it to the user in an additional message (that's why returning null here - that means, we're sending the current message and in the next cycle, we're handling logs).
  • If there's nothing in the internal buffer, we just want to proceed to handle logs without sending anything.

Also, setting state to LOGS should be the last operation, just before the return.

No, it's ok. The state should be set to sending logs regardless of whether we send the last message with the internal buffer for compaction or we just proceed to handle the logs.

This revision is now accepted and ready to land.Jul 22 2022, 1:50 AM

start method name with lowercase

prevent hanging on blocking read for logs

This revision was landed with ongoing or failed builds.Jul 25 2022, 7:14 AM
This revision was automatically updated to reflect the committed changes.