Page MenuHomePhabricator

Adding mainline repo license to the Rust Cargo manifest files
ClosedPublic

Authored by max on Jul 18 2022, 5:18 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jul 12, 2:58 AM
Unknown Object (File)
Fri, Jul 12, 2:58 AM
Unknown Object (File)
Thu, Jul 11, 9:50 AM
Unknown Object (File)
Wed, Jul 10, 5:55 PM
Unknown Object (File)
Mon, Jul 8, 4:35 PM
Unknown Object (File)
Sat, Jul 6, 5:07 PM
Unknown Object (File)
Sat, Jul 6, 5:07 PM
Unknown Object (File)
Tue, Jul 2, 5:30 AM

Details

Summary

This diff introduces adding and fixing the license in the Rust Cargo manifest files inside the project.
The license is set according to the mainline repo license (@ashoat comment in D4534).

Test Plan

Running cargo b or cargo check produces no errors.

Diff Detail

Repository
rCOMM Comm
Branch
add-fix-license-in-cargo
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

max held this revision as a draft.
max published this revision for review.Jul 18 2022, 5:20 AM
max edited the summary of this revision. (Show Details)
max added reviewers: varun, karol, ashoat, jon.

Adding @ashoat as blocking because it's license-related changes.

Android build failure is unrelated to these changes it's about a connection refused from the OpenSSL website (seems it was down).

varun requested changes to this revision.Jul 18 2022, 8:16 AM

It should just be "BSD-3-Clause", not "BSD 3-Clause 'New' or 'Revised' License". https://spdx.github.io/license-list-data/BSD-3-Clause.html

Also, do we really need a license for the binaries?

This revision now requires changes to proceed.Jul 18 2022, 8:16 AM
max edited the summary of this revision. (Show Details)

Change license name to the BSD-3-Clause.

Thanks for fixing this. Still curious if others think we need a license for the binaries

In D4552#129932, @varun wrote:

It should just be "BSD-3-Clause", not "BSD 3-Clause 'New' or 'Revised' License". https://spdx.github.io/license-list-data/BSD-3-Clause.html

Seems to be that... I've changed the license's name.

Also, do we really need a license for the binaries?

I think it's a legal requirement, but curious about @ashoat comment. If we don't need to attach a license, I'll just remove it everywhere in the Cargo.toml.

I don't think we need to list a license here unless we publish these crates. If we publish then it's probably a good idea to list a license. Either way we should avoid introducing a different license for any of these. Probably no downside in adding the license to the individual Cargo.tomls

This revision is now accepted and ready to land.Jul 18 2022, 11:48 AM