Details

Reviewers

tomek
ashoat
• jacek
• abosh

Commits

rCOMM4c883c8ccb46: [web] Rename thread to chat

Summary

Linear issue:
https://linear.app/comm/issue/ENG-1357/rename-sidebar-to-thread-in-product-copy
Diff renames thread to chat in all strings displayed to the user in web

Test Plan

Checked if strings changed as expected in web.

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

inka created this revision.Jul 14 2022, 8:09 AM

Herald added subscribers: • abosh, atul, • adrian. · View Herald TranscriptJul 14 2022, 8:09 AM

Harbormaster completed remote builds in B10534: Diff 14498.Jul 14 2022, 8:22 AM

inka requested review of this revision.Jul 14 2022, 8:22 AM

• abosh requested changes to this revision.Jul 14 2022, 8:28 AM

• abosh added inline comments.

web/modals/threads/confirm-leave-thread-modal.react.js
39 ↗	(On Diff #14498)	Should this be capitalized to match the capitalized "t" in the old version of the code? In my opinion, the lowercase 'chat' looks nicer but wanted to confirm.

This revision now requires changes to proceed.Jul 14 2022, 8:28 AM

• abosh mentioned this in D4469: [web] Introduce "Create new chat" button.Jul 14 2022, 9:55 AM

ashoat requested changes to this revision.Jul 14 2022, 12:58 PM

ashoat mentioned this in D4536: [lib,keyserver] Rename thread to chat.

ashoat added inline comments.

web/chat/thread-menu.react.js
217 ↗	(On Diff #14498)	Actually, in this rare case we are already using the correct term! "Promote" is something that applies to sidebars, which we are calling "threads" going forward. On `native` we use "Promote to channel", I think. Should we consider using the same language here?
web/modals/chat/sidebar-promote-modal.react.js
29 ↗	(On Diff #14498)	Same comment as above – consider "Promote to channel" for consistency with `native`
35 ↗	(On Diff #14498)	Let's say "Promoting a sidebar to a channel cannot be undone." (I assume sidebar -> thread will be handled in a separate diff)
41 ↗	(On Diff #14498)	Same comment as above – consider "Promote to channel" for consistency with `native`
web/modals/threads/confirm-leave-thread-modal.react.js
39 ↗	(On Diff #14498)	I agree that lowercase is better here
web/modals/threads/subchannels/subchannels-modal.react.js
116 ↗	(On Diff #14498)	Let's say "channel" instead of "chat", since subchannels can only exist inside another channel (or community, which we can consider a special kind of channel)

• abosh attached a referenced file: F102696: image.png. (Show Details)Jul 14 2022, 1:31 PM

inka added inline comments.Jul 15 2022, 2:00 AM

web/chat/thread-menu.react.js
217 ↗	(On Diff #14498)	What should I do about the upper- and lowercase? We will then have the following buttons next to each other: "Promote to channel" "Leave Chat" Since we're also changing "Yes, leave Chat" to "Yes, leave channel" maybe all buttons should have that casing convention?
web/modals/chat/sidebar-promote-modal.react.js
35 ↗	(On Diff #14498)	Yes, I will be making separate diffs for sidebar -> thread renaming.

Rename chat to channel in some places, as requested

Harbormaster completed remote builds in B10549: Diff 14514.Jul 15 2022, 2:13 AM

inka attached a referenced file: F103289: image.png. (Show Details)Jul 15 2022, 6:40 AM

• abosh accepted this revision.Jul 15 2022, 12:08 PM

This looks great!!

Separately, one note regarding the whole diff stack – even though there might not be a formal dependency relationship, it would make reviewing a little easier if the related diffs (D4536, D4538, and this one) were put in a diff stack. More details about that workflow here.

A good rule of thumb is that if you have multiple commits in a branch, then you should have multiple diffs in a stack. In this case it's probably a good idea to have these commits in the same branch, so it's probably a good idea to have these diffs in a stack.

web/chat/thread-menu.react.js
217 ↗	(On Diff #14498)	Good question!! Thanks for catching this. I agree it would be good to be consistent. Can you submit a separate diff to change "Leave Chat" to "Leave chat"?

This revision is now accepted and ready to land.Jul 17 2022, 7:40 AM

ashoat mentioned this in D4545: [lib, native, web] Rename sidebar to thread.Jul 17 2022, 8:53 AM

Updating prevoius diffs

inka added a child revision: D4538: [native] Rename thread to chat.Jul 18 2022, 1:38 AM

inka removed a child revision: D4538: [native] Rename thread to chat.

inka added a parent revision: D4538: [native] Rename thread to chat.

inka added a child revision: D4545: [lib, native, web] Rename sidebar to thread.

Harbormaster completed remote builds in B10575: Diff 14563.Jul 18 2022, 1:47 AM

inka added a child revision: D4550: [web] Unify MenuItem casing.Jul 18 2022, 2:37 AM

inka added inline comments.

web/chat/thread-menu.react.js
217 ↗	(On Diff #14498)	Sure, done!

inka marked 8 inline comments as done.Jul 18 2022, 4:35 AM

In D4539#129572, @ashoat wrote:

This looks great!!

Separately, one note regarding the whole diff stack – even though there might not be a formal dependency relationship, it would make reviewing a little easier if the related diffs (D4536, D4538, and this one) were put in a diff stack. More details about that workflow here.

A good rule of thumb is that if you have multiple commits in a branch, then you should have multiple diffs in a stack. In this case it's probably a good idea to have these commits in the same branch, so it's probably a good idea to have these diffs in a stack.

Right! I added appropriate parent and child revisions to my diffs

Thank you!

Rebase

Harbormaster failed remote builds in B10632: Diff 14626!Jul 19 2022, 3:53 AM

Harbormaster completed remote builds in B10632: Diff 14626.Jul 19 2022, 4:20 AM

Closed by commit rCOMM4c883c8ccb46: [web] Rename thread to chat (authored by Inka Sokołowska <inkasokolowska@Inkas-MacBook-Pro.local>, committed by • InkaSokolowska). · Explain WhyJul 19 2022, 4:29 AM

This revision was automatically updated to reflect the committed changes.

• InkaSokolowska added a commit: rCOMM4c883c8ccb46: [web] Rename thread to chat.

Diff 14626

View Options

web/calendar/filter-panel.react.js

This file was added.

				// @flow

				import invariant from 'invariant';

				import type {
				MessageSpec,
				RobotextParams,
				RawMessageInfoFromServerDBRowParams,
				} from './message-spec.js';
				import type { PlatformDetails } from '../../types/device-types';
				import { messageTypes } from '../../types/message-types.js';
				import type { ClientDBMessageInfo } from '../../types/message-types.js';
				import type {
				TogglePinMessageData,
				TogglePinMessageInfo,
				RawTogglePinMessageInfo,
				} from '../../types/messages/toggle-pin.js';
				import type { RawUnsupportedMessageInfo } from '../../types/messages/unsupported';
				import type { RelativeUserInfo } from '../../types/user-types.js';
				import { ET, type EntityText } from '../../utils/entity-text.js';
				import { getPinnedContentFromClientDBMessageInfo } from '../../utils/message-ops-utils.js';
				import { getPinnedContentFromMessage } from '../message-utils.js';
				import { hasMinCodeVersion } from '../version-utils.js';

				export const togglePinMessageSpec: MessageSpec<
				TogglePinMessageData,
				RawTogglePinMessageInfo,
				TogglePinMessageInfo,
				> = Object.freeze({
				messageContentForServerDB(
				data: TogglePinMessageData \| RawTogglePinMessageInfo,
				): string {
				return JSON.stringify({
				action: data.action,
				threadID: data.threadID,
				targetMessageID: data.targetMessageID,
				});
				},

				messageContentForClientDB(data: RawTogglePinMessageInfo): string {
				return this.messageContentForServerDB(data);
				},

				rawMessageInfoFromServerDBRow(
				row: Object,
				params: RawMessageInfoFromServerDBRowParams,
				): RawTogglePinMessageInfo {
				const content = JSON.parse(row.content);
				const { derivedMessages } = params;
				const targetMessage = derivedMessages.get(content.targetMessageID);
				invariant(targetMessage, 'targetMessage should be defined');

				return {
				type: messageTypes.TOGGLE_PIN,
				id: row.id.toString(),
				threadID: row.threadID.toString(),
				targetMessageID: content.targetMessageID.toString(),
				action: content.action,
				pinnedContent: getPinnedContentFromMessage(targetMessage),
				time: row.time,
				creatorID: row.creatorID.toString(),
				};
				},

				rawMessageInfoFromClientDB(
				clientDBMessageInfo: ClientDBMessageInfo,
				): RawTogglePinMessageInfo {
				invariant(
				clientDBMessageInfo.content !== undefined &&
				clientDBMessageInfo.content !== null,
				'content must be defined for TogglePin',
				);
				const content = JSON.parse(clientDBMessageInfo.content);
				const pinnedContent =
				getPinnedContentFromClientDBMessageInfo(clientDBMessageInfo);

				const rawTogglePinMessageInfo: RawTogglePinMessageInfo = {
				type: messageTypes.TOGGLE_PIN,
				id: clientDBMessageInfo.id,
				threadID: clientDBMessageInfo.thread,
				targetMessageID: content.targetMessageID,
				action: content.action,
				pinnedContent,
				time: parseInt(clientDBMessageInfo.time),
				creatorID: clientDBMessageInfo.user,
				};
				return rawTogglePinMessageInfo;
				},

				createMessageInfo(
				rawMessageInfo: RawTogglePinMessageInfo,
				creator: RelativeUserInfo,
				): TogglePinMessageInfo {
				return {
				type: messageTypes.TOGGLE_PIN,
				id: rawMessageInfo.id,
				threadID: rawMessageInfo.threadID,
				targetMessageID: rawMessageInfo.targetMessageID,
				action: rawMessageInfo.action,
				pinnedContent: rawMessageInfo.pinnedContent,
				creator,
				time: rawMessageInfo.time,
				};
				},

				rawMessageInfoFromMessageData(
				messageData: TogglePinMessageData,
				id: ?string,
				): RawTogglePinMessageInfo {
				invariant(id, 'RawTogglePinMessageInfo needs id');
				return { ...messageData, id };
				},

				robotext(
				messageInfo: TogglePinMessageInfo,
				params: RobotextParams,
				): EntityText {
				const creator = ET.user({ userInfo: messageInfo.creator });
				const action = messageInfo.action === 'pin' ? 'pinned' : 'unpinned';
				const pinnedContent = messageInfo.pinnedContent;
				const preposition = messageInfo.action === 'pin' ? 'in' : 'from';
				return ET`${creator} ${action} ${pinnedContent} ${preposition} ${ET.thread({
				display: 'alwaysDisplayShortName',
				threadID: messageInfo.threadID,
				threadType: params.threadInfo?.type,
				parentThreadID: params.threadInfo?.parentThreadID,
				})}`;
				},

				shimUnsupportedMessageInfo(
				rawMessageInfo: RawTogglePinMessageInfo,
				platformDetails: ?PlatformDetails,
				): RawTogglePinMessageInfo \| RawUnsupportedMessageInfo {
				// TODO: Change before landing
				if (hasMinCodeVersion(platformDetails, 10000)) {
				return rawMessageInfo;
				}
				const { id } = rawMessageInfo;
				invariant(id !== null && id !== undefined, 'id should be set on server');

				return {
				type: messageTypes.UNSUPPORTED,
				id,
				threadID: rawMessageInfo.threadID,
				creatorID: rawMessageInfo.creatorID,
				time: rawMessageInfo.time,
				robotext: 'toggled a message pin',
				unsupportedMessageInfo: rawMessageInfo,
				};
				},

				unshimMessageInfo(
				unwrapped: RawTogglePinMessageInfo,
				): RawTogglePinMessageInfo {
				return unwrapped;
				},

				generatesNotifs: async () => undefined,
				});

View Options

web/chat/chat-input-bar.react.js

This file was added.

				// @flow

				import invariant from 'invariant';

				import type {
				MessageSpec,
				RobotextParams,
				RawMessageInfoFromServerDBRowParams,
				} from './message-spec.js';
				import type { PlatformDetails } from '../../types/device-types';
				import { messageTypes } from '../../types/message-types.js';
				import type { ClientDBMessageInfo } from '../../types/message-types.js';
				import type {
				TogglePinMessageData,
				TogglePinMessageInfo,
				RawTogglePinMessageInfo,
				} from '../../types/messages/toggle-pin.js';
				import type { RawUnsupportedMessageInfo } from '../../types/messages/unsupported';
				import type { RelativeUserInfo } from '../../types/user-types.js';
				import { ET, type EntityText } from '../../utils/entity-text.js';
				import { getPinnedContentFromClientDBMessageInfo } from '../../utils/message-ops-utils.js';
				import { getPinnedContentFromMessage } from '../message-utils.js';
				import { hasMinCodeVersion } from '../version-utils.js';

				export const togglePinMessageSpec: MessageSpec<
				TogglePinMessageData,
				RawTogglePinMessageInfo,
				TogglePinMessageInfo,
				> = Object.freeze({
				messageContentForServerDB(
				data: TogglePinMessageData \| RawTogglePinMessageInfo,
				): string {
				return JSON.stringify({
				action: data.action,
				threadID: data.threadID,
				targetMessageID: data.targetMessageID,
				});
				},

				messageContentForClientDB(data: RawTogglePinMessageInfo): string {
				return this.messageContentForServerDB(data);
				},

				rawMessageInfoFromServerDBRow(
				row: Object,
				params: RawMessageInfoFromServerDBRowParams,
				): RawTogglePinMessageInfo {
				const content = JSON.parse(row.content);
				const { derivedMessages } = params;
				const targetMessage = derivedMessages.get(content.targetMessageID);
				invariant(targetMessage, 'targetMessage should be defined');

				return {
				type: messageTypes.TOGGLE_PIN,
				id: row.id.toString(),
				threadID: row.threadID.toString(),
				targetMessageID: content.targetMessageID.toString(),
				action: content.action,
				pinnedContent: getPinnedContentFromMessage(targetMessage),
				time: row.time,
				creatorID: row.creatorID.toString(),
				};
				},

				rawMessageInfoFromClientDB(
				clientDBMessageInfo: ClientDBMessageInfo,
				): RawTogglePinMessageInfo {
				invariant(
				clientDBMessageInfo.content !== undefined &&
				clientDBMessageInfo.content !== null,
				'content must be defined for TogglePin',
				);
				const content = JSON.parse(clientDBMessageInfo.content);
				const pinnedContent =
				getPinnedContentFromClientDBMessageInfo(clientDBMessageInfo);

				const rawTogglePinMessageInfo: RawTogglePinMessageInfo = {
				type: messageTypes.TOGGLE_PIN,
				id: clientDBMessageInfo.id,
				threadID: clientDBMessageInfo.thread,
				targetMessageID: content.targetMessageID,
				action: content.action,
				pinnedContent,
				time: parseInt(clientDBMessageInfo.time),
				creatorID: clientDBMessageInfo.user,
				};
				return rawTogglePinMessageInfo;
				},

				createMessageInfo(
				rawMessageInfo: RawTogglePinMessageInfo,
				creator: RelativeUserInfo,
				): TogglePinMessageInfo {
				return {
				type: messageTypes.TOGGLE_PIN,
				id: rawMessageInfo.id,
				threadID: rawMessageInfo.threadID,
				targetMessageID: rawMessageInfo.targetMessageID,
				action: rawMessageInfo.action,
				pinnedContent: rawMessageInfo.pinnedContent,
				creator,
				time: rawMessageInfo.time,
				};
				},

				rawMessageInfoFromMessageData(
				messageData: TogglePinMessageData,
				id: ?string,
				): RawTogglePinMessageInfo {
				invariant(id, 'RawTogglePinMessageInfo needs id');
				return { ...messageData, id };
				},

				robotext(
				messageInfo: TogglePinMessageInfo,
				params: RobotextParams,
				): EntityText {
				const creator = ET.user({ userInfo: messageInfo.creator });
				const action = messageInfo.action === 'pin' ? 'pinned' : 'unpinned';
				const pinnedContent = messageInfo.pinnedContent;
				const preposition = messageInfo.action === 'pin' ? 'in' : 'from';
				return ET`${creator} ${action} ${pinnedContent} ${preposition} ${ET.thread({
				display: 'alwaysDisplayShortName',
				threadID: messageInfo.threadID,
				threadType: params.threadInfo?.type,
				parentThreadID: params.threadInfo?.parentThreadID,
				})}`;
				},

				shimUnsupportedMessageInfo(
				rawMessageInfo: RawTogglePinMessageInfo,
				platformDetails: ?PlatformDetails,
				): RawTogglePinMessageInfo \| RawUnsupportedMessageInfo {
				// TODO: Change before landing
				if (hasMinCodeVersion(platformDetails, 10000)) {
				return rawMessageInfo;
				}
				const { id } = rawMessageInfo;
				invariant(id !== null && id !== undefined, 'id should be set on server');

				return {
				type: messageTypes.UNSUPPORTED,
				id,
				threadID: rawMessageInfo.threadID,
				creatorID: rawMessageInfo.creatorID,
				time: rawMessageInfo.time,
				robotext: 'toggled a message pin',
				unsupportedMessageInfo: rawMessageInfo,
				};
				},

				unshimMessageInfo(
				unwrapped: RawTogglePinMessageInfo,
				): RawTogglePinMessageInfo {
				return unwrapped;
				},

				generatesNotifs: async () => undefined,
				});

View Options

web/chat/chat-thread-list.react.js

This file was added.

				// @flow

				import invariant from 'invariant';

				import type {
				MessageSpec,
				RobotextParams,
				RawMessageInfoFromServerDBRowParams,
				} from './message-spec.js';
				import type { PlatformDetails } from '../../types/device-types';
				import { messageTypes } from '../../types/message-types.js';
				import type { ClientDBMessageInfo } from '../../types/message-types.js';
				import type {
				TogglePinMessageData,
				TogglePinMessageInfo,
				RawTogglePinMessageInfo,
				} from '../../types/messages/toggle-pin.js';
				import type { RawUnsupportedMessageInfo } from '../../types/messages/unsupported';
				import type { RelativeUserInfo } from '../../types/user-types.js';
				import { ET, type EntityText } from '../../utils/entity-text.js';
				import { getPinnedContentFromClientDBMessageInfo } from '../../utils/message-ops-utils.js';
				import { getPinnedContentFromMessage } from '../message-utils.js';
				import { hasMinCodeVersion } from '../version-utils.js';

				export const togglePinMessageSpec: MessageSpec<
				TogglePinMessageData,
				RawTogglePinMessageInfo,
				TogglePinMessageInfo,
				> = Object.freeze({
				messageContentForServerDB(
				data: TogglePinMessageData \| RawTogglePinMessageInfo,
				): string {
				return JSON.stringify({
				action: data.action,
				threadID: data.threadID,
				targetMessageID: data.targetMessageID,
				});
				},

				messageContentForClientDB(data: RawTogglePinMessageInfo): string {
				return this.messageContentForServerDB(data);
				},

				rawMessageInfoFromServerDBRow(
				row: Object,
				params: RawMessageInfoFromServerDBRowParams,
				): RawTogglePinMessageInfo {
				const content = JSON.parse(row.content);
				const { derivedMessages } = params;
				const targetMessage = derivedMessages.get(content.targetMessageID);
				invariant(targetMessage, 'targetMessage should be defined');

				return {
				type: messageTypes.TOGGLE_PIN,
				id: row.id.toString(),
				threadID: row.threadID.toString(),
				targetMessageID: content.targetMessageID.toString(),
				action: content.action,
				pinnedContent: getPinnedContentFromMessage(targetMessage),
				time: row.time,
				creatorID: row.creatorID.toString(),
				};
				},

				rawMessageInfoFromClientDB(
				clientDBMessageInfo: ClientDBMessageInfo,
				): RawTogglePinMessageInfo {
				invariant(
				clientDBMessageInfo.content !== undefined &&
				clientDBMessageInfo.content !== null,
				'content must be defined for TogglePin',
				);
				const content = JSON.parse(clientDBMessageInfo.content);
				const pinnedContent =
				getPinnedContentFromClientDBMessageInfo(clientDBMessageInfo);

				const rawTogglePinMessageInfo: RawTogglePinMessageInfo = {
				type: messageTypes.TOGGLE_PIN,
				id: clientDBMessageInfo.id,
				threadID: clientDBMessageInfo.thread,
				targetMessageID: content.targetMessageID,
				action: content.action,
				pinnedContent,
				time: parseInt(clientDBMessageInfo.time),
				creatorID: clientDBMessageInfo.user,
				};
				return rawTogglePinMessageInfo;
				},

				createMessageInfo(
				rawMessageInfo: RawTogglePinMessageInfo,
				creator: RelativeUserInfo,
				): TogglePinMessageInfo {
				return {
				type: messageTypes.TOGGLE_PIN,
				id: rawMessageInfo.id,
				threadID: rawMessageInfo.threadID,
				targetMessageID: rawMessageInfo.targetMessageID,
				action: rawMessageInfo.action,
				pinnedContent: rawMessageInfo.pinnedContent,
				creator,
				time: rawMessageInfo.time,
				};
				},

				rawMessageInfoFromMessageData(
				messageData: TogglePinMessageData,
				id: ?string,
				): RawTogglePinMessageInfo {
				invariant(id, 'RawTogglePinMessageInfo needs id');
				return { ...messageData, id };
				},

				robotext(
				messageInfo: TogglePinMessageInfo,
				params: RobotextParams,
				): EntityText {
				const creator = ET.user({ userInfo: messageInfo.creator });
				const action = messageInfo.action === 'pin' ? 'pinned' : 'unpinned';
				const pinnedContent = messageInfo.pinnedContent;
				const preposition = messageInfo.action === 'pin' ? 'in' : 'from';
				return ET`${creator} ${action} ${pinnedContent} ${preposition} ${ET.thread({
				display: 'alwaysDisplayShortName',
				threadID: messageInfo.threadID,
				threadType: params.threadInfo?.type,
				parentThreadID: params.threadInfo?.parentThreadID,
				})}`;
				},

				shimUnsupportedMessageInfo(
				rawMessageInfo: RawTogglePinMessageInfo,
				platformDetails: ?PlatformDetails,
				): RawTogglePinMessageInfo \| RawUnsupportedMessageInfo {
				// TODO: Change before landing
				if (hasMinCodeVersion(platformDetails, 10000)) {
				return rawMessageInfo;
				}
				const { id } = rawMessageInfo;
				invariant(id !== null && id !== undefined, 'id should be set on server');

				return {
				type: messageTypes.UNSUPPORTED,
				id,
				threadID: rawMessageInfo.threadID,
				creatorID: rawMessageInfo.creatorID,
				time: rawMessageInfo.time,
				robotext: 'toggled a message pin',
				unsupportedMessageInfo: rawMessageInfo,
				};
				},

				unshimMessageInfo(
				unwrapped: RawTogglePinMessageInfo,
				): RawTogglePinMessageInfo {
				return unwrapped;
				},

				generatesNotifs: async () => undefined,
				});

View Options

web/chat/thread-menu.react.js

This file was added.

				// @flow

				import invariant from 'invariant';

				import type {
				MessageSpec,
				RobotextParams,
				RawMessageInfoFromServerDBRowParams,
				} from './message-spec.js';
				import type { PlatformDetails } from '../../types/device-types';
				import { messageTypes } from '../../types/message-types.js';
				import type { ClientDBMessageInfo } from '../../types/message-types.js';
				import type {
				TogglePinMessageData,
				TogglePinMessageInfo,
				RawTogglePinMessageInfo,
				} from '../../types/messages/toggle-pin.js';
				import type { RawUnsupportedMessageInfo } from '../../types/messages/unsupported';
				import type { RelativeUserInfo } from '../../types/user-types.js';
				import { ET, type EntityText } from '../../utils/entity-text.js';
				import { getPinnedContentFromClientDBMessageInfo } from '../../utils/message-ops-utils.js';
				import { getPinnedContentFromMessage } from '../message-utils.js';
				import { hasMinCodeVersion } from '../version-utils.js';

				export const togglePinMessageSpec: MessageSpec<
				TogglePinMessageData,
				RawTogglePinMessageInfo,
				TogglePinMessageInfo,
				> = Object.freeze({
				messageContentForServerDB(
				data: TogglePinMessageData \| RawTogglePinMessageInfo,
				): string {
				return JSON.stringify({
				action: data.action,
				threadID: data.threadID,
				targetMessageID: data.targetMessageID,
				});
				},

				messageContentForClientDB(data: RawTogglePinMessageInfo): string {
				return this.messageContentForServerDB(data);
				},

				rawMessageInfoFromServerDBRow(
				row: Object,
				params: RawMessageInfoFromServerDBRowParams,
				): RawTogglePinMessageInfo {
				const content = JSON.parse(row.content);
				const { derivedMessages } = params;
				const targetMessage = derivedMessages.get(content.targetMessageID);
				invariant(targetMessage, 'targetMessage should be defined');

				return {
				type: messageTypes.TOGGLE_PIN,
				id: row.id.toString(),
				threadID: row.threadID.toString(),
				targetMessageID: content.targetMessageID.toString(),
				action: content.action,
				pinnedContent: getPinnedContentFromMessage(targetMessage),
				time: row.time,
				creatorID: row.creatorID.toString(),
				};
				},

				rawMessageInfoFromClientDB(
				clientDBMessageInfo: ClientDBMessageInfo,
				): RawTogglePinMessageInfo {
				invariant(
				clientDBMessageInfo.content !== undefined &&
				clientDBMessageInfo.content !== null,
				'content must be defined for TogglePin',
				);
				const content = JSON.parse(clientDBMessageInfo.content);
				const pinnedContent =
				getPinnedContentFromClientDBMessageInfo(clientDBMessageInfo);

				const rawTogglePinMessageInfo: RawTogglePinMessageInfo = {
				type: messageTypes.TOGGLE_PIN,
				id: clientDBMessageInfo.id,
				threadID: clientDBMessageInfo.thread,
				targetMessageID: content.targetMessageID,
				action: content.action,
				pinnedContent,
				time: parseInt(clientDBMessageInfo.time),
				creatorID: clientDBMessageInfo.user,
				};
				return rawTogglePinMessageInfo;
				},

				createMessageInfo(
				rawMessageInfo: RawTogglePinMessageInfo,
				creator: RelativeUserInfo,
				): TogglePinMessageInfo {
				return {
				type: messageTypes.TOGGLE_PIN,
				id: rawMessageInfo.id,
				threadID: rawMessageInfo.threadID,
				targetMessageID: rawMessageInfo.targetMessageID,
				action: rawMessageInfo.action,
				pinnedContent: rawMessageInfo.pinnedContent,
				creator,
				time: rawMessageInfo.time,
				};
				},

				rawMessageInfoFromMessageData(
				messageData: TogglePinMessageData,
				id: ?string,
				): RawTogglePinMessageInfo {
				invariant(id, 'RawTogglePinMessageInfo needs id');
				return { ...messageData, id };
				},

				robotext(
				messageInfo: TogglePinMessageInfo,
				params: RobotextParams,
				): EntityText {
				const creator = ET.user({ userInfo: messageInfo.creator });
				const action = messageInfo.action === 'pin' ? 'pinned' : 'unpinned';
				const pinnedContent = messageInfo.pinnedContent;
				const preposition = messageInfo.action === 'pin' ? 'in' : 'from';
				return ET`${creator} ${action} ${pinnedContent} ${preposition} ${ET.thread({
				display: 'alwaysDisplayShortName',
				threadID: messageInfo.threadID,
				threadType: params.threadInfo?.type,
				parentThreadID: params.threadInfo?.parentThreadID,
				})}`;
				},

				shimUnsupportedMessageInfo(
				rawMessageInfo: RawTogglePinMessageInfo,
				platformDetails: ?PlatformDetails,
				): RawTogglePinMessageInfo \| RawUnsupportedMessageInfo {
				// TODO: Change before landing
				if (hasMinCodeVersion(platformDetails, 10000)) {
				return rawMessageInfo;
				}
				const { id } = rawMessageInfo;
				invariant(id !== null && id !== undefined, 'id should be set on server');

				return {
				type: messageTypes.UNSUPPORTED,
				id,
				threadID: rawMessageInfo.threadID,
				creatorID: rawMessageInfo.creatorID,
				time: rawMessageInfo.time,
				robotext: 'toggled a message pin',
				unsupportedMessageInfo: rawMessageInfo,
				};
				},

				unshimMessageInfo(
				unwrapped: RawTogglePinMessageInfo,
				): RawTogglePinMessageInfo {
				return unwrapped;
				},

				generatesNotifs: async () => undefined,
				});