Differential D4574

[web] Hide "Users in parent channel" header for threads without parent in `AddMembersModal`
ClosedPublic
Actions

Authored by • jacek on Jul 19 2022, 3:50 AM.

Tags

None

Referenced Files

	F3363139: D4574.diff
	Mon, Nov 25, 12:26 AM

	Unknown Object (File)
	Tue, Nov 19, 4:46 PM

	Unknown Object (File)
	Tue, Nov 19, 4:46 PM

	Unknown Object (File)
	Tue, Nov 19, 4:46 PM

	Unknown Object (File)
	Tue, Nov 19, 4:45 PM

	Unknown Object (File)
	Oct 17 2024, 9:51 PM

	Unknown Object (File)
	Oct 17 2024, 9:51 PM

	Unknown Object (File)
	Oct 17 2024, 9:51 PM

View All 65 Files

Subscribers

Details

Reviewers

tomek
atul

Commits

rCOMM832036c9acb6: [web] Hide "Users in parent channel" header for threads without parent in…

Summary

The diff is solution for: https://linear.app/comm/issue/ENG-1396/addmembersmodal-on-web-shows-users-in-parent-channel-for-community
It provides additional check if channel (that we want to add users to) has parent channel, and hides "Users in parent channel" label if there is no parent channel

Screenshot_Google Chrome_2022-07-19_125821.png (384×633 px, 21 KB)

Test Plan

Tested the modal in Genesis and one manually created COMMUNITY_ROOT thread (to achive something similar to Comm channel in production, where the issue appeared) and confirmed, that the header is not displayed and the modal looks good.

Diff Detail

Repository

Branch

jacek/add-members-fix

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• jacek created this revision.Jul 19 2022, 3:50 AM

Herald added subscribers: • abosh, • adrian, ashoat. · View Herald TranscriptJul 19 2022, 3:50 AM

• jacek edited the summary of this revision. (Show Details)Jul 19 2022, 3:59 AM

Harbormaster returned this revision to the author for changes because remote builds failed.Jul 19 2022, 4:04 AM

Harbormaster failed remote builds in B10635: Diff 14629!

Harbormaster completed remote builds in B10635: Diff 14629.Jul 19 2022, 4:27 AM

• jacek requested review of this revision.Jul 19 2022, 4:27 AM

tomek accepted this revision.Jul 20 2022, 5:12 AM

This revision is now accepted and ready to land.Jul 20 2022, 5:12 AM

Closed by commit rCOMM832036c9acb6: [web] Hide "Users in parent channel" header for threads without parent in… (authored by • jacek). · Explain WhyJul 20 2022, 6:57 AM

This revision was automatically updated to reflect the committed changes.

• jacek added a commit: rCOMM832036c9acb6: [web] Hide "Users in parent channel" header for threads without parent in….

Revision Contents
Changeset List

Path

Size

web/

modals/

threads/

members/

add-members-group.react.js

7 lines

add-members-list.react.js

22 lines

add-members-modal.react.js

1 line

Diff 14629

web/modals/threads/members/add-members-group.react.js

Loading...

web/modals/threads/members/add-members-list.react.js

Loading...

web/modals/threads/members/add-members-modal.react.js

Loading...