Page MenuHomePhabricator

[services] Lib - remove include iostream
ClosedPublic

Authored by karol on Jul 21 2022, 3:46 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 8, 8:28 PM
Unknown Object (File)
Fri, Nov 8, 8:28 PM
Unknown Object (File)
Fri, Nov 8, 8:28 PM
Unknown Object (File)
Fri, Nov 8, 8:13 AM
Unknown Object (File)
Tue, Nov 5, 2:05 AM
Unknown Object (File)
Sep 26 2024, 6:13 PM
Unknown Object (File)
Sep 26 2024, 6:13 PM
Unknown Object (File)
Sep 26 2024, 6:13 PM

Details

Summary

Depends on D4594

Removing #include <iostream> everywhere. This include was used for std::cout and since we quit using it, we can clear out all such includes.

Test Plan

Tunnelbroker, backup and blob build.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Jul 21 2022, 3:53 AM
Harbormaster failed remote builds in B10716: Diff 14755!
karol edited the test plan for this revision. (Show Details)
karol added reviewers: tomek, max.
Harbormaster returned this revision to the author for changes because remote builds failed.Jul 21 2022, 4:11 AM
Harbormaster failed remote builds in B10727: Diff 14766!

Services built properly

This revision is now accepted and ready to land.Jul 21 2022, 6:55 AM
This revision now requires review to proceed.Jul 21 2022, 7:39 AM
This revision is now accepted and ready to land.Jul 22 2022, 3:45 AM
This revision was landed with ongoing or failed builds.Jul 26 2022, 7:11 AM
This revision was automatically updated to reflect the committed changes.