Page MenuHomePhabricator

[services] Tunnelbroker - Move init logging to the global tools
ClosedPublic

Authored by karol on Jul 21 2022, 3:44 AM.
Tags
None
Referenced Files
F3301046: D4588.diff
Sun, Nov 17, 11:30 PM
Unknown Object (File)
Fri, Nov 8, 8:28 PM
Unknown Object (File)
Fri, Nov 8, 8:28 PM
Unknown Object (File)
Fri, Nov 8, 8:28 PM
Unknown Object (File)
Fri, Nov 8, 8:28 PM
Unknown Object (File)
Fri, Nov 8, 8:13 AM
Unknown Object (File)
Tue, Nov 5, 2:05 AM
Unknown Object (File)
Mon, Nov 4, 3:18 AM

Details

Summary

We want to use glog in other services, not only tunnelbroker. Therefore, I think we should move initializing function to the global tools so it can be accessed from the blob and the backup as well.

Test Plan
cd services
yarn run-tunnelbroker-in-sandbox

Tunnelbroker builds without problems.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Jul 21 2022, 3:45 AM
Harbormaster failed remote builds in B10708: Diff 14747!
karol edited the test plan for this revision. (Show Details)
karol added reviewers: tomek, max.
Harbormaster returned this revision to the author for changes because remote builds failed.Jul 21 2022, 3:59 AM
Harbormaster failed remote builds in B10720: Diff 14759!

Services built properly

This revision is now accepted and ready to land.Jul 21 2022, 6:01 AM
This revision now requires review to proceed.Jul 21 2022, 7:38 AM
tomek added inline comments.
services/tunnelbroker/src/server.cpp
42

Is there a downside of using argv[0]?

This revision is now accepted and ready to land.Jul 22 2022, 3:21 AM
services/tunnelbroker/src/server.cpp
42

argv[0] is something like ./cmake/build/bin/tunnelbroker. I just find it clearer to hardcode the short name.

services/tunnelbroker/src/server.cpp
42

Ok, that makes sense. Agree, your approach is better.