Page MenuHomePhabricator
Differential D4598

[services] Tests - Run formatter
ClosedPublic
Actions

Authored by • karol on Jul 21 2022, 6:05 AM.
Tags
None
Referenced Files
F3398609: D4598.diff
Sun, Dec 1, 11:37 PM
Unknown Object (File)
Sun, Nov 10, 10:05 PM
Unknown Object (File)
Sat, Nov 9, 12:02 PM
Unknown Object (File)
Sat, Nov 9, 11:59 AM
Unknown Object (File)
Sat, Nov 9, 10:19 AM
Unknown Object (File)
Oct 15 2024, 9:11 PM
Unknown Object (File)
Sep 27 2024, 4:07 PM
Unknown Object (File)
Sep 27 2024, 4:07 PM
View All Files
Subscribers
• abosh
• adrian
ashoat
atul
tomek

Details

Reviewers
tomek
varun
Commits
rCOMM04748179453f: [services] Tests - Run formatter
Summary

Depends on D4555

Running rust formater on the tests.

Test Plan

None really, it's just code styling, the code compiles and runs as before.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• karol created this revision.Jul 21 2022, 6:05 AM
Herald added subscribers: • abosh, atul, • adrian and 2 others. · View Herald TranscriptJul 21 2022, 6:05 AM
• karol edited the summary of this revision. (Show Details)Jul 21 2022, 6:05 AM
• karol added a parent revision: D4555: [services] Backup - pull backup - change logic to use att holders out of data section.
• karol added a child revision: D4556: [services] Backup - pull backup - change tests.
• karol mentioned this in D4556: [services] Backup - pull backup - change tests.
• karol edited the summary of this revision. (Show Details)
• karol edited the test plan for this revision. (Show Details)
• karol added reviewers: tomek, varun.
Harbormaster completed remote builds in B10733: Diff 14772.Jul 21 2022, 6:26 AM
• karol requested review of this revision.Jul 21 2022, 6:26 AM
varun accepted this revision.Jul 21 2022, 11:08 AM

Is the linter not complaining if you commit changes that aren't formatted correctly?

This revision is now accepted and ready to land.Jul 21 2022, 11:08 AM
• karol added a comment.Jul 22 2022, 12:45 AM

It does now. It didn't work properly after I switched to m1 but I fixed my local env.

tomek accepted this revision.Jul 22 2022, 2:01 AM
• karol updated this revision to Diff 14855.Jul 25 2022, 7:01 AM

rebase

This revision was landed with ongoing or failed builds.Jul 25 2022, 7:14 AM
Closed by commit rCOMM04748179453f: [services] Tests - Run formatter (authored by • karol). · Explain Why
This revision was automatically updated to reflect the committed changes.
• karol added a commit: rCOMM04748179453f: [services] Tests - Run formatter.
Harbormaster completed remote builds in B10802: Diff 14855.Jul 25 2022, 7:14 AM

Revision Contents
Changeset List

PathSize
services/
commtest/
tests/
backup/
12 lines
5 lines
lib/
6 lines

Diff 14772

View Options

services/commtest/tests/backup/pull_backup.rs

Loading...
View Options

services/commtest/tests/backup_test.rs

Loading...
View Options

services/commtest/tests/lib/tools.rs

Loading...