[services] Tests - Backup - Create new backup
ClosedPublic
Actions

Authored by • karol on Jul 26 2022, 2:50 AM.

Details

Reviewers

tomek
varun

Commits

rCOMM21ab868fa7bc: [services] Tests - Backup - Create new backup

Summary

Depends on D4631

Adding a piece of test for "add attachments for backup" functionality.

Test Plan

cd services
yarn run-performance-tests backup 1

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• karol created this revision.Jul 26 2022, 2:50 AM

Herald added subscribers: • abosh, atul, • adrian and 2 others. · View Herald TranscriptJul 26 2022, 2:50 AM

• karol added a child revision: D4632: [services] Tests - Backup - Add attachments for backups.Jul 26 2022, 2:53 AM

• karol edited the summary of this revision. (Show Details)

• karol edited the test plan for this revision. (Show Details)

• karol added reviewers: tomek, varun.

• karol added a parent revision: D4631: [services] Tests - Backup - Initialize performance tests.

Harbormaster completed remote builds in B10867: Diff 14930.Jul 26 2022, 3:02 AM

• karol requested review of this revision.Jul 26 2022, 3:02 AM

tomek accepted this revision.Jul 26 2022, 5:14 AM

tomek added inline comments.

services/commtest/tests/backup_performance_test.rs
81	Why do we need to explicitly drop? I think it is almost never a good idea.

This revision is now accepted and ready to land.Jul 26 2022, 5:14 AM

• karol added inline comments.Jul 26 2022, 6:57 AM

services/commtest/tests/backup_performance_test.rs
81	Please, read my answer in https://phab.comm.dev/D4633#133164

rebase

Harbormaster completed remote builds in B10889: Diff 14967.Jul 26 2022, 7:15 AM

rebase

Harbormaster completed remote builds in B10946: Diff 15056.Jul 28 2022, 6:35 AM

Closed by commit rCOMM21ab868fa7bc: [services] Tests - Backup - Create new backup (authored by • karol). · Explain WhyAug 2 2022, 3:02 AM

This revision was automatically updated to reflect the committed changes.

• karol added a commit: rCOMM21ab868fa7bc: [services] Tests - Backup - Create new backup.

Revision Contents
Changeset List

Path

Size

services/

commtest/

tests/

backup_performance_test.rs

52 lines

Diff 14930

View Options

services/commtest/tests/backup_performance_test.rs

[services] Tests - Backup - Create new backupClosedPublicActions