[web] Simplify `MessageListContainer` and `ChatTabs` CSS
ClosedPublic
Actions

Authored by • jacek on Jul 21 2022, 6:46 AM.

Details

Reviewers

tomek
atul
ashoat

Commits

rCOMM095e619020e3: [web] Simplify `MessageListContainer` and `ChatTabs` CSS

Summary

Introduce some CSS improvements as a follow-up diff after D4434.
The app looks the same as before, but absolute positioning and hardcoded 400px margins were removed and replaced with flex, so the code is easier to maintain.
We don't have blue color in out color palette, but I kept existing border color unchanged, but exported into variable.

Test Plan

Run web app, tested most of the views performing different operations with different zoom options to confirm the view scrolls correctly and looks like before. Tried to attach multimedia to confirm the border looks like before.
Performed tests on Chrome, Safari and Firefox.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• jacek created this revision.Jul 21 2022, 6:46 AM

Herald added subscribers: • abosh, • adrian, ashoat. · View Herald TranscriptJul 21 2022, 6:46 AM

Harbormaster completed remote builds in B10737: Diff 14776.Jul 21 2022, 6:58 AM

• jacek requested review of this revision.Jul 21 2022, 6:58 AM

Can you modify the test plan to make sure you test on all relevant browsers? We shouldn't be making big layout changes like this without testing every browser

This revision now requires changes to proceed.Jul 22 2022, 8:49 AM

• jacek edited the test plan for this revision. (Show Details)Jul 25 2022, 1:25 AM

In D4599#131980, @ashoat wrote:

Can you modify the test plan to make sure you test on all relevant browsers? We shouldn't be making big layout changes like this without testing every browser

Sure, I tested the changes on Chrome, Safari and Firefox.

• jacek added a parent revision: D4434: [web] Separate `ChatMessageListContainer` from `ChatMessageList`.Jul 25 2022, 3:25 AM

Looks a lot better, thanks!

Thank you!!

This revision is now accepted and ready to land.Jul 25 2022, 6:21 AM

rebase

Harbormaster completed remote builds in B10870: Diff 14945.Jul 26 2022, 3:26 AM

Closed by commit rCOMM095e619020e3: [web] Simplify `MessageListContainer` and `ChatTabs` CSS (authored by • jacek). · Explain WhyJul 26 2022, 3:32 AM

This revision was automatically updated to reflect the committed changes.

• jacek added a commit: rCOMM095e619020e3: [web] Simplify `MessageListContainer` and `ChatTabs` CSS.