[draft] [services] Backup - Add Logs
AbandonedPublic
Actions

Authored by michal on Jul 27 2022, 6:33 AM.

Details

Reviewers

tomek
• max
• jon
• karol

Summary

Depends on D4652

Adding Logs to the backup service. Putting this up as a draft since I'm not 100% sure about this. Curious about your opinions.

Test Plan

cd services
yarn run-backup-service-in-sandbox

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• karol created this revision.Jul 27 2022, 6:33 AM

Herald added subscribers: • abosh, atul, • adrian and 2 others. · View Herald TranscriptJul 27 2022, 6:33 AM

• karol retitled this revision from [services] Backup - Add Logs to [draft] [services] Backup - Add Logs.Jul 27 2022, 6:35 AM

• karol edited the summary of this revision. (Show Details)

• karol edited the test plan for this revision. (Show Details)

• karol added a parent revision: D4652: [draft] [services] Blob - Add Logs.

Harbormaster completed remote builds in B10911: Diff 15011.Jul 27 2022, 6:45 AM

• karol requested review of this revision.Jul 27 2022, 6:45 AM

• karol added reviewers: tomek, • max.Jul 28 2022, 1:32 AM

Looking at this diff, the idea from https://phab.comm.dev/D4652#inline-29573 sounds really beneficial.

services/backup/src/DatabaseManager.cpp
24	Do you think we can safely log user id? @ashoat what do you think?
services/backup/src/Reactors/server/CreateNewBackupReactor.cpp
54	Is logging this safe? Can it be used in some attacks?
services/backup/src/Reactors/server/PullBackupReactor.cpp
85–88	Can we avoid this confusing notation and simply write values next to their descriptions (in all the places)?
119	Not related to this diff, but are we still affected by this issue?
services/backup/src/Reactors/server/SendLogReactor.cpp
58	Is writing this as an int really useful?
129–131	We're computing the size twice. Can we avoid it?

This revision now requires changes to proceed.Jul 28 2022, 4:58 AM

ashoat added inline comments.Jul 28 2022, 6:39 AM

services/backup/src/DatabaseManager.cpp
24	Let's avoid that, see here https://phab.comm.dev/D4652#133661

I think this diff should be canceled because the Backup service going to Rust now. I can commandeer and close it if @tomek doesn't mind.

Herald added a reviewer: • jon. · View Herald TranscriptDec 29 2022, 2:23 AM

Old diff, that isn't applicable to the current backup service.

Revision Contents
Changeset List

Path

Size

services/

backup/

src/

DatabaseEntities/

BackupItem.cpp

10 lines

LogItem.cpp

10 lines

DatabaseManager.cpp

20 lines

Reactors/

client/

blob/

BlobGetClientReactor.cpp

3 lines

BlobPutClientReactor.cpp

13 lines

server/

AddAttachmentsUtility.cpp

14 lines

CreateNewBackupReactor.cpp

24 lines

PullBackupReactor.cpp

69 lines

SendLogReactor.cpp

23 lines

Tools.cpp

7 lines

Diff 15011

View Options

services/backup/src/DatabaseEntities/BackupItem.cpp

Show First 20 Lines • Show All 47 Lines • ▼ Show 20 Lines	pub fn updateSessionItemIsOnline(
sessionID: &str,		sessionID: &str,
isOnline: bool,		isOnline: bool,
) -> Result<()>;		) -> Result<()>;
pub fn updateSessionItemDeviceToken(		pub fn updateSessionItemDeviceToken(
sessionID: &str,		sessionID: &str,
newNotifToken: &str,		newNotifToken: &str,
) -> Result<()>;		) -> Result<()>;
pub fn getMessagesFromDatabase(deviceID: &str) -> Result<Vec<MessageItem>>;		pub fn getMessagesFromDatabase(deviceID: &str) -> Result<Vec<MessageItem>>;
		pub fn putMessagesIntoDatabase(
		messages: &Vec<MessageItem>,
		) -> Result<Vec<String>>;
pub fn eraseMessagesFromAMQP(deviceID: &str) -> Result<()>;		pub fn eraseMessagesFromAMQP(deviceID: &str) -> Result<()>;
pub fn ackMessageFromAMQP(deliveryTag: u64) -> Result<()>;		pub fn ackMessageFromAMQP(deliveryTag: u64) -> Result<()>;
pub fn waitMessageFromDeliveryBroker(deviceID: &str)		pub fn waitMessageFromDeliveryBroker(deviceID: &str)
-> Result<MessageItem>;		-> Result<MessageItem>;
pub fn removeMessages(		pub fn removeMessages(
deviceID: &str,		deviceID: &str,
messagesIDs: &Vec<String>,		messagesIDs: &Vec<String>,
) -> Result<()>;		) -> Result<()>;
}		}
}		}

View Options

services/backup/src/DatabaseEntities/LogItem.cpp

Show First 20 Lines • Show All 47 Lines • ▼ Show 20 Lines	pub fn updateSessionItemIsOnline(
sessionID: &str,		sessionID: &str,
isOnline: bool,		isOnline: bool,
) -> Result<()>;		) -> Result<()>;
pub fn updateSessionItemDeviceToken(		pub fn updateSessionItemDeviceToken(
sessionID: &str,		sessionID: &str,
newNotifToken: &str,		newNotifToken: &str,
) -> Result<()>;		) -> Result<()>;
pub fn getMessagesFromDatabase(deviceID: &str) -> Result<Vec<MessageItem>>;		pub fn getMessagesFromDatabase(deviceID: &str) -> Result<Vec<MessageItem>>;
		pub fn putMessagesIntoDatabase(
		messages: &Vec<MessageItem>,
		) -> Result<Vec<String>>;
pub fn eraseMessagesFromAMQP(deviceID: &str) -> Result<()>;		pub fn eraseMessagesFromAMQP(deviceID: &str) -> Result<()>;
pub fn ackMessageFromAMQP(deliveryTag: u64) -> Result<()>;		pub fn ackMessageFromAMQP(deliveryTag: u64) -> Result<()>;
pub fn waitMessageFromDeliveryBroker(deviceID: &str)		pub fn waitMessageFromDeliveryBroker(deviceID: &str)
-> Result<MessageItem>;		-> Result<MessageItem>;
pub fn removeMessages(		pub fn removeMessages(
deviceID: &str,		deviceID: &str,
messagesIDs: &Vec<String>,		messagesIDs: &Vec<String>,
) -> Result<()>;		) -> Result<()>;
}		}
}		}

View Options

services/backup/src/DatabaseManager.cpp

Show First 20 Lines • Show All 47 Lines • ▼ Show 20 Lines	pub fn updateSessionItemIsOnline(
sessionID: &str,		sessionID: &str,
isOnline: bool,		isOnline: bool,
) -> Result<()>;		) -> Result<()>;
pub fn updateSessionItemDeviceToken(		pub fn updateSessionItemDeviceToken(
sessionID: &str,		sessionID: &str,
newNotifToken: &str,		newNotifToken: &str,
) -> Result<()>;		) -> Result<()>;
pub fn getMessagesFromDatabase(deviceID: &str) -> Result<Vec<MessageItem>>;		pub fn getMessagesFromDatabase(deviceID: &str) -> Result<Vec<MessageItem>>;
		pub fn putMessagesIntoDatabase(
		messages: &Vec<MessageItem>,
		) -> Result<Vec<String>>;
pub fn eraseMessagesFromAMQP(deviceID: &str) -> Result<()>;		pub fn eraseMessagesFromAMQP(deviceID: &str) -> Result<()>;
pub fn ackMessageFromAMQP(deliveryTag: u64) -> Result<()>;		pub fn ackMessageFromAMQP(deliveryTag: u64) -> Result<()>;
pub fn waitMessageFromDeliveryBroker(deviceID: &str)		pub fn waitMessageFromDeliveryBroker(deviceID: &str)
-> Result<MessageItem>;		-> Result<MessageItem>;
pub fn removeMessages(		pub fn removeMessages(
deviceID: &str,		deviceID: &str,
messagesIDs: &Vec<String>,		messagesIDs: &Vec<String>,
) -> Result<()>;		) -> Result<()>;
}		}
}		}

View Options

services/backup/src/Reactors/client/blob/BlobGetClientReactor.cpp

Show First 20 Lines • Show All 47 Lines • ▼ Show 20 Lines	pub fn updateSessionItemIsOnline(
sessionID: &str,		sessionID: &str,
isOnline: bool,		isOnline: bool,
) -> Result<()>;		) -> Result<()>;
pub fn updateSessionItemDeviceToken(		pub fn updateSessionItemDeviceToken(
sessionID: &str,		sessionID: &str,
newNotifToken: &str,		newNotifToken: &str,
) -> Result<()>;		) -> Result<()>;
pub fn getMessagesFromDatabase(deviceID: &str) -> Result<Vec<MessageItem>>;		pub fn getMessagesFromDatabase(deviceID: &str) -> Result<Vec<MessageItem>>;
		pub fn putMessagesIntoDatabase(
		messages: &Vec<MessageItem>,
		) -> Result<Vec<String>>;
pub fn eraseMessagesFromAMQP(deviceID: &str) -> Result<()>;		pub fn eraseMessagesFromAMQP(deviceID: &str) -> Result<()>;
pub fn ackMessageFromAMQP(deliveryTag: u64) -> Result<()>;		pub fn ackMessageFromAMQP(deliveryTag: u64) -> Result<()>;
pub fn waitMessageFromDeliveryBroker(deviceID: &str)		pub fn waitMessageFromDeliveryBroker(deviceID: &str)
-> Result<MessageItem>;		-> Result<MessageItem>;
pub fn removeMessages(		pub fn removeMessages(
deviceID: &str,		deviceID: &str,
messagesIDs: &Vec<String>,		messagesIDs: &Vec<String>,
) -> Result<()>;		) -> Result<()>;
}		}
}		}

View Options

services/backup/src/Reactors/client/blob/BlobPutClientReactor.cpp

Show First 20 Lines • Show All 47 Lines • ▼ Show 20 Lines	pub fn updateSessionItemIsOnline(
sessionID: &str,		sessionID: &str,
isOnline: bool,		isOnline: bool,
) -> Result<()>;		) -> Result<()>;
pub fn updateSessionItemDeviceToken(		pub fn updateSessionItemDeviceToken(
sessionID: &str,		sessionID: &str,
newNotifToken: &str,		newNotifToken: &str,
) -> Result<()>;		) -> Result<()>;
pub fn getMessagesFromDatabase(deviceID: &str) -> Result<Vec<MessageItem>>;		pub fn getMessagesFromDatabase(deviceID: &str) -> Result<Vec<MessageItem>>;
		pub fn putMessagesIntoDatabase(
		messages: &Vec<MessageItem>,
		) -> Result<Vec<String>>;
pub fn eraseMessagesFromAMQP(deviceID: &str) -> Result<()>;		pub fn eraseMessagesFromAMQP(deviceID: &str) -> Result<()>;
pub fn ackMessageFromAMQP(deliveryTag: u64) -> Result<()>;		pub fn ackMessageFromAMQP(deliveryTag: u64) -> Result<()>;
pub fn waitMessageFromDeliveryBroker(deviceID: &str)		pub fn waitMessageFromDeliveryBroker(deviceID: &str)
-> Result<MessageItem>;		-> Result<MessageItem>;
pub fn removeMessages(		pub fn removeMessages(
deviceID: &str,		deviceID: &str,
messagesIDs: &Vec<String>,		messagesIDs: &Vec<String>,
) -> Result<()>;		) -> Result<()>;
}		}
}		}

View Options

services/backup/src/Reactors/server/AddAttachmentsUtility.cpp

Show First 20 Lines • Show All 47 Lines • ▼ Show 20 Lines	pub fn updateSessionItemIsOnline(
sessionID: &str,		sessionID: &str,
isOnline: bool,		isOnline: bool,
) -> Result<()>;		) -> Result<()>;
pub fn updateSessionItemDeviceToken(		pub fn updateSessionItemDeviceToken(
sessionID: &str,		sessionID: &str,
newNotifToken: &str,		newNotifToken: &str,
) -> Result<()>;		) -> Result<()>;
pub fn getMessagesFromDatabase(deviceID: &str) -> Result<Vec<MessageItem>>;		pub fn getMessagesFromDatabase(deviceID: &str) -> Result<Vec<MessageItem>>;
		pub fn putMessagesIntoDatabase(
		messages: &Vec<MessageItem>,
		) -> Result<Vec<String>>;
pub fn eraseMessagesFromAMQP(deviceID: &str) -> Result<()>;		pub fn eraseMessagesFromAMQP(deviceID: &str) -> Result<()>;
pub fn ackMessageFromAMQP(deliveryTag: u64) -> Result<()>;		pub fn ackMessageFromAMQP(deliveryTag: u64) -> Result<()>;
pub fn waitMessageFromDeliveryBroker(deviceID: &str)		pub fn waitMessageFromDeliveryBroker(deviceID: &str)
-> Result<MessageItem>;		-> Result<MessageItem>;
pub fn removeMessages(		pub fn removeMessages(
deviceID: &str,		deviceID: &str,
messagesIDs: &Vec<String>,		messagesIDs: &Vec<String>,
) -> Result<()>;		) -> Result<()>;
}		}
}		}