Export a cmake project
Depends on D3867
Differential D4295
[services] Export cpp tools as CMake project • jon on Jun 19 2022, 11:24 AM. Authored by Tags None Referenced Files
Details Export a cmake project Depends on D3867 Checkout https://phab.comm.dev/D4452 (which should have all of the file paths normalized), then run: nix develop && cd native/cpp/CommonCpp/Tools && mkdir build && cd build && cmake .. && make
Diff Detail
Event TimelineThere are a very large number of changes, so older changes are hidden. Show Older Changes Comment Actions btw iOS build had the following error: error: Build input file cannot be found: '/opt/homebrew/var/buildkite-agent/builds/comms-MacBook-Air-local-1/comm/ios-build/native/cpp/CommonCpp/grpc/_generated/tunnelbroker.grpc.pb.cc' (in target 'NotificationService' from project 'Comm') but xcodebuild just hung instead of exiting.
Comment Actions Resigning since I'm usually not a good person to set as a first-pass reviewer. Exceptions here
Comment Actions Apart from the parenthesis issue (which should be addressed before landing), it looks like Android and iOS aren't building? Ideally every diff should pass CI, but there have been exceptions in the past when making broad changes (eg React Native upgrade). Are we expecting this diff to pass CI, or is this one of those situations where the stack will be landed "atomically" on master to avoid breaking things? edit: JK, answered in the next diff (D4296):
Comment Actions (This isn't on @jonringer-comm's queue right now – might be worth hitting Request Changes so he sees it) Comment Actions Nice, will accept right after the CMake Lint issue is addressed (comment on line 46 is too long, should be easy to cut 2 characters) atuls-MacBook-Pro:build atul$ make [ 50%] Building CXX object CMakeFiles/comm-tools.dir/WorkerThread.cpp.o [100%] Linking CXX static library libcomm-tools.a [100%] Built target comm-tools Comment Actions Address comment
|