Page MenuHomePhabricator

[Nix] Expose rustc to development shell
ClosedPublic

Authored by jon on Aug 18 2022, 9:14 AM.
Tags
None
Referenced Files
F3348840: D4872.id15742.diff
Fri, Nov 22, 4:11 PM
F3348839: D4872.id15748.diff
Fri, Nov 22, 4:11 PM
Unknown Object (File)
Tue, Nov 5, 2:06 AM
Unknown Object (File)
Oct 12 2024, 6:44 AM
Unknown Object (File)
Oct 6 2024, 9:14 AM
Unknown Object (File)
Oct 6 2024, 9:14 AM
Unknown Object (File)
Oct 6 2024, 9:13 AM
Unknown Object (File)
Oct 6 2024, 9:10 AM
Subscribers

Details

Reviewers
ashoat
abosh
varun
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Commits
rCOMMc1b13c76ac12: [Nix] Expose rustc to development shell
Summary

Add rustc to PATH on nix develop shell.

This isn't necessary when invoking cargo, as nixpkgs' cargo uses a wrapper
script to force rustc on PATH before invoking the cargo command. However, this
can be useful if someone would like to invoke rustc directly within the shell.

https://linear.app/comm/issue/ENG-1667

Test Plan
nix develop
which rustc # points to nix store

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Owners added a reviewer: Restricted Owners Package.Aug 18 2022, 9:14 AM
Harbormaster returned this revision to the author for changes because remote builds failed.Aug 18 2022, 9:18 AM
Harbormaster failed remote builds in B11445: Diff 15742!
This revision is now accepted and ready to land.Aug 18 2022, 9:59 AM
This revision was automatically updated to reflect the committed changes.