Differential D4741
[services] Tunnelbroker - Add `waitUntilReady` function in AmqpManager Authored by • max on Aug 4 2022, 10:50 AM. Tags None Referenced Files
Details This diff is a part of the stack to fix the AMQP client reconnection issue. The waitUntilReady function handles waiting for reconnection. This function uses on send() and ack() methods which send and acknowledge the message correspondingly. Related linear task: ENG-1495 Successfully built using yarn run-tunnelbroker-service-in-sandbox command.
Diff Detail
Event TimelineComment Actions I don't think that this is the correct way of waiting for this condition to occur. First of all, it might never happen as access to amqpReady isn't synchronized. We should probably use some concurrency primitives rather than a sleep. Comment Actions std::atomic<bool> amqpReady is an atomic variable and thread-safe and synchronized on the onReady, onError events in a follow-up D4744 diff (D4744 fixes the reconnection logic). This change needs to be projected as a part of the stack.
We can use conditional variables for that for example or something like that, but it doesn't make sense to overengineering here because we will wait for a reconnection interval anyway and just check after it (please look at the D4744 part of the stack). It will make sense when we will use a variation timeout in a follow-up ENG-1381. So it can be part of these future changes.
| ||||||||||||||||||||||||||||||||||||||||||||||||||||