Page MenuHomePhabricator
Differential D5153

[Backup] Use only one tokio runtime
ClosedPublic
Actions

Authored by • jon on Sep 15 2022, 10:56 AM.
Tags
None
Referenced Files
F3648144: D5153.id16763.diff
Sun, Jan 5, 1:56 AM
F3640538: D5153.id16759.diff
Sat, Jan 4, 12:58 PM
F3640537: D5153.id16715.diff
Sat, Jan 4, 12:58 PM
F3640534: D5153.id16763.diff
Sat, Jan 4, 12:58 PM
F3640515: D5153.id.diff
Sat, Jan 4, 12:57 PM
F3640499: D5153.diff
Sat, Jan 4, 12:54 PM
Unknown Object (File)
Fri, Jan 3, 4:10 PM
Unknown Object (File)
Fri, Jan 3, 12:58 AM
View All Files
Subscribers
• abosh
ashoat
tomek

Details

Reviewers
atul
varun
• karol
• max
Commits
rCOMM040488e9923b: [Backup] Use only one tokio runtime
Summary

We only need one runtime to do asynchronous calls. Using two or more
is an anti-pattern.

https://linear.app/comm/issue/ENG-1808
https://linear.app/comm/issue/ENG-1806

Test Plan
cd services/backup
rm -rf build && mkdir build && cd build && cmake .. && make -j

Diff Detail

Repository
rCOMM Comm
Branch
jonringer/remove-duplicate-runtimes
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
services/
backup/
blob_client/
src/
3 lines
9 lines
3 lines

Diff 16715

View Options

services/backup/blob_client/src/get_client.rs

Loading...
View Options

services/backup/blob_client/src/lib.rs

Loading...
View Options

services/backup/blob_client/src/put_client.rs

Loading...