Page MenuHomePhabricator
Differential D5153

[Backup] Use only one tokio runtime
ClosedPublic
Actions

Authored by • jon on Sep 15 2022, 10:56 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, May 29, 6:32 AM
Unknown Object (File)
Wed, May 29, 6:32 AM
Unknown Object (File)
Wed, May 29, 6:32 AM
Unknown Object (File)
Wed, May 29, 6:31 AM
Unknown Object (File)
Wed, May 29, 6:30 AM
Unknown Object (File)
Sun, May 26, 8:06 PM
Unknown Object (File)
Wed, May 22, 9:29 AM
Unknown Object (File)
Sat, May 18, 6:51 AM
View All Files
Subscribers
• abosh
ashoat
tomek

Details

Reviewers
atul
varun
• karol
• max
Commits
rCOMM040488e9923b: [Backup] Use only one tokio runtime
Summary

We only need one runtime to do asynchronous calls. Using two or more
is an anti-pattern.

https://linear.app/comm/issue/ENG-1808
https://linear.app/comm/issue/ENG-1806

Test Plan
cd services/backup
rm -rf build && mkdir build && cd build && cmake .. && make -j

Diff Detail

Repository
rCOMM Comm
Branch
jonringer/remove-duplicate-runtimes
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
services/
backup/
blob_client/
src/
3 lines
9 lines
5 lines

Diff 16759

View Options

services/backup/blob_client/src/get_client.rs

Loading...
View Options

services/backup/blob_client/src/lib.rs

Loading...
View Options

services/backup/blob_client/src/put_client.rs

Loading...