Page MenuHomePhabricator
Differential D4969

[Docs] Fix nix store typo
ClosedPublic
Actions

Authored by • jon on Aug 26 2022, 3:49 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Dec 14, 5:52 AM
Unknown Object (File)
Sat, Dec 14, 5:52 AM
Unknown Object (File)
Sat, Dec 14, 5:52 AM
Unknown Object (File)
Sat, Dec 14, 5:52 AM
Unknown Object (File)
Sat, Dec 14, 5:52 AM
Unknown Object (File)
Sat, Dec 14, 5:52 AM
Unknown Object (File)
Sat, Dec 14, 5:51 AM
Unknown Object (File)
Sat, Dec 14, 5:43 AM
View All Files
Subscribers
atul
tomek

Details

Reviewers
varun
ashoat
• abosh
Commits
rCOMMcf19b66d22ba: [Docs] Fix nix store typo
Summary

Minor fix a typo. It's /nix/store/ not /nix/store-.

Test Plan

N/A

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• jon created this revision.Aug 26 2022, 3:49 PM
Herald added subscribers: atul, tomek. · View Herald TranscriptAug 26 2022, 3:49 PM
• jon added a parent revision: D4968: [Docs] Update supported workflow information.Aug 26 2022, 3:50 PM
Harbormaster completed remote builds in B11657: Diff 16031.Aug 26 2022, 3:59 PM
• jon requested review of this revision.Aug 26 2022, 3:59 PM
• jon added a child revision: D4970: [Docs] Provide nixified version of tableplus.Aug 26 2022, 4:38 PM
ashoat accepted this revision.Aug 26 2022, 8:41 PM
This revision is now accepted and ready to land.Aug 26 2022, 8:41 PM
• jon updated this revision to Diff 16082.Aug 29 2022, 11:13 AM

Rebase with changes

• abosh accepted this revision.Aug 29 2022, 11:15 AM
• abosh added inline comments.
docs/nix_dev_env.md
87 ↗(On Diff #16082)
Harbormaster completed remote builds in B11694: Diff 16082.Aug 29 2022, 11:23 AM
• jon updated this revision to Diff 16086.Aug 29 2022, 4:52 PM

Fix respective mis-spelling

Harbormaster completed remote builds in B11697: Diff 16086.Aug 29 2022, 5:02 PM
ashoat requested changes to this revision.Sep 13 2022, 2:02 PM
ashoat added inline comments.
docs/nix_dev_env.md
87 ↗(On Diff #16086)

This section introduces more questions than it answers. For instance, "simply adding the respective toolchains to nativeBuildInputs" begs the question... what is nativeBuildInputs

I think we should either simplify the language or scrap it altogether.

This revision now requires changes to proceed.Sep 13 2022, 2:02 PM
• jon planned changes to this revision.Sep 13 2022, 3:25 PM
• jon added inline comments.
docs/nix_dev_env.md
87 ↗(On Diff #16086)

I plan to tackle this on https://github.com/divnix/nix-book/issues/21. But I can just leave off that last bit, I think

This model can be extended through shell hooks to support other build toolchains such as pkg-config, cmake, and many other language specific package managers

Is good enough for the intuition

• jon updated this revision to Diff 16724.Sep 15 2022, 5:38 PM
• jon marked 2 inline comments as done.

Simplify "How Nix introduces..." section

• jon added inline comments.Sep 15 2022, 5:39 PM
docs/nix_dev_env.md
87 ↗(On Diff #16086)

reworded the section to be simpler

• jon updated this revision to Diff 16725.Sep 15 2022, 5:44 PM

Apply suggestions

Harbormaster completed remote builds in B12193: Diff 16724.Sep 15 2022, 5:46 PM
Harbormaster completed remote builds in B12194: Diff 16725.Sep 15 2022, 5:54 PM
ashoat accepted this revision.Sep 15 2022, 7:11 PM

Great!!

This revision is now accepted and ready to land.Sep 15 2022, 7:11 PM
Closed by commit rCOMMcf19b66d22ba: [Docs] Fix nix store typo (authored by • jon). · Explain WhySep 19 2022, 3:11 PM
This revision was automatically updated to reflect the committed changes.
• jon added a commit: rCOMMcf19b66d22ba: [Docs] Fix nix store typo.

Revision Contents
Changeset List

PathSize
docs/
2 lines

Diff 16724

View Options

docs/nix_dev_env.md

Loading...