The buttons in the relationship chat settings now have colors that are consistent with the other relationship prompt buttons found in the app
Depends on D5088
Differential D5100
[web] Introduce colors for relationship action buttons ginsu on Sep 9 2022, 8:40 AM. Authored by Tags None Referenced Files
Details The buttons in the relationship chat settings now have colors that are consistent with the other relationship prompt buttons found in the app Depends on D5088 Please view the screenshots to see the before and after of the changes I made: Before: After: Add friend and block case Withdraw friend request case Accept and reject friend request case unfriend case unblock case
Diff Detail
Event TimelineComment Actions Thanks for including all of those screenshots in the Test Plan! One thing I noticed is that the icons aren't aligned and their position varies pretty wildly: There are a lot of ways we can use flex box, etc to lay this out in a way that looks cleaner (eg flex-row with an icon pushed to the left and text centered within a container for remaining width). What we can do is break this into two separate diffs.
Comment Actions Looks very close, once we move the buttonVariant stuff outside of the useMemo() we should be good to go!
|