Page MenuHomePhabricator
Differential D5160

[services] Remove no-op variable assignment in Tunnelbroker CMakeLists.txt
ClosedPublic
Actions

Authored by ashoat on Sep 16 2022, 8:03 AM.
Tags
None
Referenced Files
F3121661: D5160.id16758.diff
Fri, Nov 1, 8:33 AM
F3121623: D5160.id16777.diff
Fri, Nov 1, 8:24 AM
F3120914: D5160.diff
Fri, Nov 1, 6:42 AM
Unknown Object (File)
Tue, Oct 29, 1:46 PM
Unknown Object (File)
Sun, Oct 27, 4:32 AM
Unknown Object (File)
Tue, Oct 15, 9:23 AM
Unknown Object (File)
Wed, Oct 9, 8:41 PM
Unknown Object (File)
Tue, Oct 8, 8:20 AM
View All Files
Subscribers
• abosh
atul
• karol
• max
tomek

Details

Reviewers
• jon
Commits
rCOMMe69bf8d64369: [services] Remove no-op variable assignment in Tunnelbroker CMakeLists.txt
Summary

Context here

Test Plan

I actually haven't tested this. Hoping CI will handle it... the change seems reasonable

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ashoat created this revision.Sep 16 2022, 8:03 AM
Herald added subscribers: • abosh, • karol, atul, tomek. · View Herald TranscriptSep 16 2022, 8:03 AM
ashoat mentioned this in D5119: [Chore] Cleanup tunnelbroker CMakeLists.txt.Sep 16 2022, 8:03 AM
Harbormaster returned this revision to the author for changes because remote builds failed.Sep 16 2022, 8:05 AM
Harbormaster failed remote builds in B12217: Diff 16758!
ashoat added a subscriber: • max.Sep 16 2022, 8:07 AM

Not sure what the Tunnelbroker CI failures are about... @jon, @max – any context?

ashoat requested review of this revision.Sep 16 2022, 10:52 AM
Harbormaster completed remote builds in B12217: Diff 16758.Sep 16 2022, 10:54 AM
ashoat added a comment.Sep 16 2022, 11:36 AM

Ah nice it's all green now

• jon added a comment.EditedSep 16 2022, 11:47 AM

Not sure what the Tunnelbroker CI failures are about... @jon, @max – any context?

That issue is being tracked https://linear.app/comm/issue/ENG-1836/investigate-protobuf-failures-in-nix-ci

Essentially one of the builders has a tainted environment which I can't reproduce on my local intel mac

• jon accepted this revision.Sep 16 2022, 11:47 AM

LGTM, thanks :)

This revision is now accepted and ready to land.Sep 16 2022, 11:47 AM
Closed by commit rCOMMe69bf8d64369: [services] Remove no-op variable assignment in Tunnelbroker CMakeLists.txt (authored by ashoat). · Explain WhySep 16 2022, 12:09 PM
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMMe69bf8d64369: [services] Remove no-op variable assignment in Tunnelbroker CMakeLists.txt.

Revision Contents
Changeset List

PathSize
services/
tunnelbroker/
6 lines

Diff 16777

View Options

services/tunnelbroker/CMakeLists.txt

Loading...