[Backup] Initialize logger with tokio runtime
ClosedPublic
Actions

Authored by • jon on Sep 12 2022, 3:49 PM.

Details

Reviewers

varun
tomek
• max
• karol

Commits

rCOMM961e8b18054b: [Backup] Initialize logger with tokio runtime

Summary

Loggers in rust need to be initialized once. Since we don't really
have a main, I instead snuck it in with initializing the tokio runtime.

Part of https://linear.app/comm/issue/ENG-1717

Test Plan

Run backup server
View logs

Diff Detail

Repository

rCOMM Comm

Branch

jonringer/backup-add-logging (branched from master)

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• jon created this revision.Sep 12 2022, 3:49 PM

Herald added subscribers: • abosh, ashoat. · View Herald TranscriptSep 12 2022, 3:49 PM

• jon added a parent revision: D5123: [Backup] Add logging to blob_client.Sep 12 2022, 3:49 PM

Harbormaster completed remote builds in B12108: Diff 16615.Sep 12 2022, 3:59 PM

• jon requested review of this revision.Sep 12 2022, 3:59 PM

(Unfortunately don't have enough Rust background to give this a proper review.)

This revision now requires changes to proceed.Sep 13 2022, 9:48 AM

Crap, sorry meant to resign.

This revision now requires review to proceed.Sep 13 2022, 9:49 AM

I cannot patch this diff locally. I fetched tags and pulled changes from the remote. Please, fix this (or maybe I missed something?).

This doesn't work when I try to patch on the top of D5123, otherwise, it looks alright.

This revision is now accepted and ready to land.Sep 14 2022, 3:57 AM

going to rebase on top of https://phab.comm.dev/D5153

Target new runtime location

This revision is now accepted and ready to land.Sep 16 2022, 2:31 PM

Add info log to demonstrate usage

Harbormaster completed remote builds in B12231: Diff 16780.Sep 16 2022, 2:41 PM

Harbormaster completed remote builds in B12232: Diff 16781.

• max accepted this revision.Sep 16 2022, 3:46 PM

Closed by commit rCOMM961e8b18054b: [Backup] Initialize logger with tokio runtime (authored by • jon). · Explain WhySep 19 2022, 12:39 PM

This revision was automatically updated to reflect the committed changes.

• jon added a commit: rCOMM961e8b18054b: [Backup] Initialize logger with tokio runtime.

• max mentioned this in D5182: [services] Tunnelbroker - Add `env_logger` to the Rust library.Sep 19 2022, 3:30 PM

• max mentioned this in rCOMMa34c0adcca8c: [services] Tunnelbroker - Add `env_logger` to the Rust library.Sep 20 2022, 12:24 PM

Revision Contents
Changeset List

Path

Size

services/

backup/

blob_client/

src/

lib.rs

7 lines

Diff 16780

View Options

services/backup/blob_client/src/lib.rs

[Backup] Initialize logger with tokio runtimeClosedPublicActions