Page MenuHomePhabricator
Differential D5208

[services][identity] update user's public keys in ddb during PAKE login
ClosedPublic
Actions

Authored by varun on Sep 21 2022, 11:43 PM.
Tags
None
Referenced Files
F3394248: D5208.id17008.diff
Sat, Nov 30, 6:32 PM
F3394213: D5208.id16972.diff
Sat, Nov 30, 6:18 PM
Unknown Object (File)
Mon, Nov 18, 10:22 PM
Unknown Object (File)
Mon, Nov 18, 7:32 PM
Unknown Object (File)
Sat, Nov 9, 7:38 PM
Unknown Object (File)
Sat, Nov 9, 7:38 PM
Unknown Object (File)
Sat, Nov 9, 7:38 PM
Unknown Object (File)
Sat, Nov 9, 7:35 PM
View All Files
Subscribers
• abosh
ashoat
atul

Details

Reviewers
tomek
• jon
Commits
rCOMMaa4790881d3b: [services][identity] update user's public keys in ddb during PAKE login
Summary

If a user logs in, we should update the users table to reflect the potentially new deviceID-userPublicKey mapping.

We should refactor these service methods to not loop. Tracked here.

Depends on D5200

Test Plan

verified that PAKE login on a new device updates the devices map in dynamodb to reflect the new public key

Diff Detail

Repository
rCOMM Comm
Branch
identity (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

varun created this revision.Sep 21 2022, 11:43 PM
Herald added subscribers: • abosh, atul, ashoat. · View Herald TranscriptSep 21 2022, 11:43 PM
varun added a child revision: D5209: [services][identity] update user's public keys in ddb during wallet login.Sep 21 2022, 11:51 PM
Harbormaster completed remote builds in B12361: Diff 16972.Sep 21 2022, 11:53 PM
varun requested review of this revision.Sep 21 2022, 11:53 PM
varun updated this revision to Diff 17008.Sep 22 2022, 12:38 PM

remove unnecessary closure

Harbormaster failed remote builds in B12392: Diff 17008!Sep 22 2022, 12:49 PM
Harbormaster completed remote builds in B12392: Diff 17008.Sep 22 2022, 12:54 PM
• jon added inline comments.Sep 22 2022, 1:33 PM
services/identity/src/service.rs
604–609 ↗(On Diff #17008)

Feel like we got a lot going on here in a deeply nested fashion.
Not sure how i feel about having a nested await inside of the construction of a value.

varun added inline comments.Sep 22 2022, 1:54 PM
services/identity/src/service.rs
604–609 ↗(On Diff #17008)

yeah that's true. i have a linear task (linked in summary) to refactor this whole thing anyway. will tackle then

• jon accepted this revision.Sep 22 2022, 4:56 PM
tomek accepted this revision.Sep 23 2022, 6:02 AM
This revision is now accepted and ready to land.Sep 23 2022, 6:02 AM
Closed by commit rCOMMaa4790881d3b: [services][identity] update user's public keys in ddb during PAKE login (authored by varun). · Explain WhySep 23 2022, 11:22 AM
This revision was automatically updated to reflect the committed changes.
varun added a commit: rCOMMaa4790881d3b: [services][identity] update user's public keys in ddb during PAKE login.

Revision Contents
Changeset List

PathSize
services/
identity/
src/
39 lines

Diff 16972

View Options

services/identity/src/service.rs

Loading...