Split createMessageReply to createMessageReply and createMessageQuote
ClosedPublic
Actions

Authored by inka on Sep 22 2022, 6:13 AM.

Details

Reviewers

tomek
michal
• jakub
ashoat

Commits

rCOMM8ae399fb766c: Split createMessageReply to createMessageReply and createMessageQuote

Summary

In message reporting we need to create a quote that will be placed at the end of a message and as such doesn't need newlines at the end.
Related discussion in D4941.

Test Plan

See that replying to a message still works, even for messages with multiple newlines in a row.

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

inka created this revision.Sep 22 2022, 6:13 AM

Herald added subscribers: • abosh, atul. · View Herald TranscriptSep 22 2022, 6:13 AM

Adding @ashoat because this diff was created in response to his comments on D4941

inka mentioned this in D4941: [keyserver] Add message report creator.Sep 22 2022, 6:20 AM

inka added a child revision: D4941: [keyserver] Add message report creator.

Harbormaster completed remote builds in B12374: Diff 16987.Sep 22 2022, 6:26 AM

inka requested review of this revision.Sep 22 2022, 6:26 AM

Looks great!

This revision is now accepted and ready to land.Sep 22 2022, 6:29 AM

tomek accepted this revision.Sep 23 2022, 8:54 AM

Rebase

Harbormaster completed remote builds in B12547: Diff 17218.Sep 30 2022, 3:57 AM

Closed by commit rCOMM8ae399fb766c: Split createMessageReply to createMessageReply and createMessageQuote (authored by • InkaSokolowska). · Explain WhySep 30 2022, 5:27 AM

This revision was automatically updated to reflect the committed changes.

• InkaSokolowska added a commit: rCOMM8ae399fb766c: Split createMessageReply to createMessageReply and createMessageQuote.

Revision Contents
Changeset List

Path

Size

lib/

shared/

message-utils.js

10 lines

Diff 16987

View Options

lib/shared/message-utils.js

Split createMessageReply to createMessageReply and createMessageQuoteClosedPublicActions