This differential modifies CommCoreModule to use GlobalDBSingleton instead of creating its own thread.
Details
Details
Summary
Test Plan
Build the app. The fact thst it works is a test since it changes the way JS accesses database
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Branch
- marcin/db-singleton
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
Herald added a reviewer: • jon. · View Herald TranscriptSep 27 2022, 4:17 AM2022-09-27 04:17:50 (UTC-7)
marcin added a parent revision: D5231: Define global singleton db C++ API..Sep 27 2022, 4:18 AM2022-09-27 04:18:13 (UTC-7)
Harbormaster completed remote builds in B12452: Diff 17099.Sep 27 2022, 4:25 AM2022-09-27 04:25:31 (UTC-7)
This revision is now accepted and ready to land.Sep 27 2022, 9:12 AM2022-09-27 09:12:33 (UTC-7)
Harbormaster failed remote builds in B12612: Diff 17336!Oct 5 2022, 2:59 AM2022-10-05 02:59:31 (UTC-7)
Harbormaster completed remote builds in B12618: Diff 17342.Oct 5 2022, 3:21 AM2022-10-05 03:21:11 (UTC-7)
Harbormaster completed remote builds in B12662: Diff 17397.Oct 7 2022, 2:15 AM2022-10-07 02:15:44 (UTC-7)
Harbormaster completed remote builds in B12666: Diff 17402.Oct 7 2022, 2:41 AM2022-10-07 02:41:44 (UTC-7)
Closed by commit rCOMM3e2ba909377e: Modify commCoreModule to use GlobalDBSingleton instead of creating its own… (authored by marcin). · Explain WhyOct 7 2022, 2:51 AM2022-10-07 02:51:13 (UTC-7)
This revision was automatically updated to reflect the committed changes.