Page MenuHomePhabricator
Differential D5232

Modify commCoreModule to use GlobalDBSingleton instead of creating its own thread
ClosedPublic
Actions

Authored by marcin on Sep 27 2022, 4:17 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 17, 11:24 AM
Unknown Object (File)
Thu, Apr 17, 12:31 AM
Unknown Object (File)
Thu, Apr 17, 12:30 AM
Unknown Object (File)
Wed, Apr 16, 10:06 AM
Unknown Object (File)
Mon, Apr 14, 8:48 PM
Unknown Object (File)
Mon, Apr 14, 12:27 PM
Unknown Object (File)
Fri, Apr 11, 4:49 PM
Unknown Object (File)
Wed, Apr 9, 1:38 AM
View All Files
Subscribers
• abosh
ashoat

Details

Reviewers
atul
tomek
• jon
Commits
rCOMM3e2ba909377e: Modify commCoreModule to use GlobalDBSingleton instead of creating its own…
Summary

This differential modifies CommCoreModule to use GlobalDBSingleton instead of creating its own thread.

Test Plan

Build the app. The fact thst it works is a test since it changes the way JS accesses database

Diff Detail

Repository
rCOMM Comm
Branch
marcin/db-singleton
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

marcin created this revision.Sep 27 2022, 4:17 AM
Herald added a reviewer: • jon. · View Herald TranscriptSep 27 2022, 4:17 AM
Herald added subscribers: • abosh, ashoat. · View Herald Transcript
marcin added a parent revision: D5231: Define global singleton db C++ API..Sep 27 2022, 4:18 AM
Harbormaster completed remote builds in B12452: Diff 17099.Sep 27 2022, 4:25 AM
marcin requested review of this revision.Sep 27 2022, 4:25 AM
marcin added a child revision: D5233: Implement GlobalDbSingleton API for both platforms.Sep 27 2022, 4:51 AM
marcin added a child revision: D5235: Implement C++ class to pass Java lambda (Runnable interface implementation) to C++ code).Sep 27 2022, 4:58 AM
• jon accepted this revision.Sep 27 2022, 9:12 AM
This revision is now accepted and ready to land.Sep 27 2022, 9:12 AM
tomek accepted this revision.Sep 28 2022, 3:12 AM
marcin updated this revision to Diff 17336.Oct 5 2022, 2:50 AM

Redefine API

marcin removed child revisions: D5235: Implement C++ class to pass Java lambda (Runnable interface implementation) to C++ code), D5233: Implement GlobalDbSingleton API for both platforms.Oct 5 2022, 2:55 AM
marcin removed a parent revision: D5231: Define global singleton db C++ API..
marcin added a parent revision: D5233: Implement GlobalDbSingleton API for both platforms.Oct 5 2022, 2:58 AM
marcin added child revisions: D5234: Use GlobalDBSingleton when touching database from the native iOS code., D5235: Implement C++ class to pass Java lambda (Runnable interface implementation) to C++ code).
Harbormaster failed remote builds in B12612: Diff 17336!Oct 5 2022, 2:59 AM
marcin updated this revision to Diff 17342.Oct 5 2022, 3:11 AM

Fix compilation bug

Harbormaster completed remote builds in B12618: Diff 17342.Oct 5 2022, 3:21 AM
tomek accepted this revision.Oct 6 2022, 6:54 AM
marcin updated this revision to Diff 17397.Oct 7 2022, 2:05 AM

Rebase before landing

Harbormaster completed remote builds in B12662: Diff 17397.Oct 7 2022, 2:15 AM
marcin updated this revision to Diff 17402.Oct 7 2022, 2:32 AM

Rebase before landing

Harbormaster completed remote builds in B12666: Diff 17402.Oct 7 2022, 2:41 AM
Closed by commit rCOMM3e2ba909377e: Modify commCoreModule to use GlobalDBSingleton instead of creating its own… (authored by marcin). · Explain WhyOct 7 2022, 2:51 AM
This revision was automatically updated to reflect the committed changes.
marcin added a commit: rCOMM3e2ba909377e: Modify commCoreModule to use GlobalDBSingleton instead of creating its own….

Revision Contents
Changeset List

PathSize
native/
cpp/
CommonCpp/
NativeModules/
2 lines
72 lines

Diff 17099

View Options

native/cpp/CommonCpp/NativeModules/CommCoreModule.h

Loading...
View Options

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp

Loading...