Page MenuHomePhabricator

Use GlobalDbSingleton API on Android to update database in reponse to notifs in CommNotificationsHandler.
ClosedPublic

Authored by marcin on Sep 27 2022, 5:48 AM.
Tags
None
Referenced Files
F3348764: D5237.id17414.diff
Fri, Nov 22, 4:01 PM
Unknown Object (File)
Sat, Nov 9, 8:11 PM
Unknown Object (File)
Sat, Nov 9, 8:11 PM
Unknown Object (File)
Sat, Nov 9, 8:11 PM
Unknown Object (File)
Sat, Nov 9, 8:11 PM
Unknown Object (File)
Sat, Nov 9, 8:11 PM
Unknown Object (File)
Sat, Nov 9, 8:09 PM
Unknown Object (File)
Tue, Nov 5, 2:07 AM

Details

Summary

We use GlobalDBSingleton API in Java for two things: 1. Safely update database from CommNotificationsHandler.

Test Plan

Build the app, send notifications and rescinds. Ensure app is not crashing.

Diff Detail

Repository
rCOMM Comm
Branch
marcin/db-singleton
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

looks fine to me, but haven't used java in 10+ years.

This revision is now accepted and ready to land.Sep 28 2022, 4:08 AM
marcin retitled this revision from Use GlobalDbSingleton API on Android to update database in reponse to notifs in CommNotificationsHandler and to eagerly enable multithreading when app is launched to Use GlobalDbSingleton API on Android to update database in reponse to notifs in CommNotificationsHandler..Oct 5 2022, 2:59 AM
marcin edited the summary of this revision. (Show Details)