Page MenuHomePhabricator
Differential D5238

Replace throw with log and early return when trying to update thread that does exists in the database in response to rescind
ClosedPublic
Actions

Authored by marcin on Sep 27 2022, 6:38 AM.
Tags
None
Referenced Files
F3246555: D5238.diff
Fri, Nov 15, 12:38 AM
Unknown Object (File)
Tue, Nov 12, 1:37 AM
Unknown Object (File)
Mon, Nov 11, 4:38 AM
Unknown Object (File)
Sat, Nov 9, 7:39 PM
Unknown Object (File)
Sat, Nov 9, 7:39 PM
Unknown Object (File)
Sat, Nov 9, 7:39 PM
Unknown Object (File)
Sat, Nov 9, 7:35 PM
Unknown Object (File)
Thu, Nov 7, 8:06 AM
View All Files
Subscribers
• abosh
ashoat
atul

Details

Reviewers
tomek
• jon
Commits
rCOMM2b34f355dd81: Replace throw with log and early return when trying to update thread that does…
Summary

This differential replaces throw with log and early return upon arrival of the rescind that contains threadID which does not exist in local db on device. Situation when such a rescind arrives is possible and is not considered a bug anywhere soe throwin an exception here is not appriate. This differential also solves crash described here: https://linear.app/comm/issue/ENG-1892/ios-145-crash

Test Plan

Reproduce the following scenarion twice - before and after applying this differential:

  1. User A creates a chat with User B
  2. User B opens the chat on web and marks the chat as read

We should expect that User B's mobile app will crash before this diff and just log information after applying this diff.

Diff Detail

Repository
rCOMM Comm
Branch
marcin/eng-1892
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

marcin created this revision.Sep 27 2022, 6:38 AM
Herald added a reviewer: • jon. · View Herald TranscriptSep 27 2022, 6:38 AM
Herald added subscribers: • abosh, atul, ashoat. · View Herald Transcript
Harbormaster completed remote builds in B12462: Diff 17109.Sep 27 2022, 6:49 AM
marcin requested review of this revision.Sep 27 2022, 6:49 AM
tomek accepted this revision.Sep 28 2022, 2:49 AM

That makes sense. One scenario where it can happen is receiving a notification for a thread that was deleted just before the notif was delivered.

This revision is now accepted and ready to land.Sep 28 2022, 2:49 AM
marcin updated this revision to Diff 17136.Sep 28 2022, 2:51 AM

Rebase master before landing

Harbormaster completed remote builds in B12484: Diff 17136.Sep 28 2022, 2:59 AM
Closed by commit rCOMM2b34f355dd81: Replace throw with log and early return when trying to update thread that does… (authored by marcin). · Explain WhySep 28 2022, 3:03 AM
This revision was automatically updated to reflect the committed changes.
marcin added a commit: rCOMM2b34f355dd81: Replace throw with log and early return when trying to update thread that does….

Revision Contents
Changeset List

PathSize
native/
cpp/
CommonCpp/
NativeModules/
PersistentStorageUtilities/
ThreadOperationsUtilities/
3 lines

Diff 17136

View Options

native/cpp/CommonCpp/NativeModules/PersistentStorageUtilities/ThreadOperationsUtilities/ThreadOperations.cpp

Loading...