Paths

Table of Contentst

Differential D5279

[web] Notifications dialog - change name
ClosedPublic
Actions

Authored by michal on Oct 3 2022, 2:20 AM.

Tags

None

Referenced Files

	F2102038: D5279.diff
	Mon, Jun 24, 11:29 PM

	Unknown Object (File)
	Sat, Jun 22, 4:07 AM

	Unknown Object (File)
	Sat, Jun 22, 4:07 AM

	Unknown Object (File)
	Sat, Jun 22, 4:07 AM

	Unknown Object (File)
	Sat, Jun 22, 4:07 AM

	Unknown Object (File)
	Wed, Jun 19, 1:07 PM

	Unknown Object (File)
	Wed, Jun 19, 1:03 PM

	Unknown Object (File)
	Mon, Jun 17, 5:51 AM

Subscribers

Details

Reviewers

tomek
atul
• abosh
ashoat

Commits

rCOMM4fda171b4a66: [web] Notifications dialog - change name

Summary

ENG-1729
Changes notifications dialog title for sidebars from "Channel notifications" to "Thread notifications".

Test Plan

Test if the title is correct for sidebars and non-sidebars.

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

michal created this revision.Oct 3 2022, 2:20 AM

Herald added a subscriber: ashoat. · View Herald TranscriptOct 3 2022, 2:20 AM

michal added a child revision: D5280: [web] Notifications dialog - disable background option.Oct 3 2022, 2:25 AM

Harbormaster completed remote builds in B12576: Diff 17278.Oct 3 2022, 2:31 AM

michal requested review of this revision.Oct 3 2022, 2:31 AM

ashoat accepted this revision.Oct 3 2022, 6:13 AM

ashoat added inline comments.

web/modals/threads/notifications/notifications-modal.react.js
94 ↗	(On Diff #17278)	Let's use `threadIsSidebar` for this. This will be slightly more convenient for us if we ever introduce a second kind of sidebar

This revision is now accepted and ready to land.Oct 3 2022, 6:13 AM

Use threadIsSidebar, rebase

Harbormaster completed remote builds in B12593: Diff 17315.Oct 4 2022, 2:22 AM

Closed by commit rCOMM4fda171b4a66: [web] Notifications dialog - change name (authored by Michal Gniadek <michal.gniadek@swmansion.com>). · Explain WhyOct 5 2022, 5:05 AM

This revision was automatically updated to reflect the committed changes.

Michal Gniadek <michal.gniadek@swmansion.com> added a commit: rCOMM4fda171b4a66: [web] Notifications dialog - change name.

Revision Contents
Changeset List

Path

Size

web/

modals/

threads/

notifications/

notifications-modal.react.js

8 lines

Diff 17315

web/modals/threads/notifications/notifications-modal.react.js

Loading...