Differential D5346
Add the match and parse functions for spoiler text Authored by rohan on Oct 11 2022, 11:28 AM. Tags None Referenced Files
Details Added the match and parse functions in order to execute the RegEx in the previous diff (in the stack), so we can then capture the spoiler text and transform it later. Linear Issue: https://linear.app/comm/issue/ENG-1982/set-up-the-match-and-parse-functions-in-markdownjs-in-the-lib Depends on D5335 The testing for this will come in the subsequent diff, where we
Diff Detail
Event TimelineComment Actions looks good to me! Everything makes sense and seems to follow what was in the simple-markdown docs Comment Actions Adding @kamil, who has looked at match/parse functions in SimpleMarkdown recently. Some questions inline
Comment Actions Discussed in my sync with @ashoat - there's no need for custom match and parse methods, we can instead use the ones from SimpleMarkdown, and I will update the subsequent diff with the new spoiler rule | |||||||||||||||||||||||||||||||||||||