Page MenuHomePhabricator
Differential D5350

Remove deleting cxx files after build
ClosedPublic
Actions

Authored by inka on Oct 12 2022, 2:10 AM.
Tags
None
Referenced Files
F3525644: D5350.id17564.diff
Mon, Dec 23, 5:56 PM
F3525608: D5350.id17503.diff
Mon, Dec 23, 5:55 PM
Unknown Object (File)
Tue, Dec 3, 3:41 PM
Unknown Object (File)
Wed, Nov 27, 9:06 PM
Unknown Object (File)
Tue, Nov 26, 5:07 PM
Unknown Object (File)
Mon, Nov 25, 10:35 PM
Unknown Object (File)
Mon, Nov 25, 10:35 PM
Unknown Object (File)
Mon, Nov 25, 10:35 PM
View All Files
Subscribers
• abosh
ashoat
atul
tomek

Details

Reviewers
varun
Commits
rCOMMd80ac01bc30f: Remove deleting cxx files after build
Summary

linear issue: ENG-2013
Deleting lib.rs.h, lib.rs.cc and cxx.h after build causes IDE to display errors, and to be unable to index our cxx functions.
These files are in .gitignore, so this should only change what is seen locally.

Test Plan

Build ios, stop ios, see that lib.rs.h, lib.rs.cc and cxx.h files are still present in native/native-rust_library/

Diff Detail

Repository
rCOMM Comm
Branch
inka/remove_deleting_cxx_files
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

inka created this revision.Oct 12 2022, 2:10 AM
Herald added subscribers: • abosh, atul, tomek, ashoat. · View Herald TranscriptOct 12 2022, 2:10 AM
inka edited the summary of this revision. (Show Details)Oct 12 2022, 2:10 AM
Harbormaster completed remote builds in B12741: Diff 17503.Oct 12 2022, 2:19 AM
inka requested review of this revision.Oct 12 2022, 2:19 AM
varun accepted this revision.Oct 13 2022, 8:18 AM

let's remove the clean-up-native-rust-library.sh script as well since we're not calling it anymore

This revision is now accepted and ready to land.Oct 13 2022, 8:18 AM
inka updated this revision to Diff 17564.Oct 14 2022, 12:48 AM

remove clean-up-native-rust-library.sh

Harbormaster completed remote builds in B12790: Diff 17564.Oct 14 2022, 12:58 AM
Closed by commit rCOMMd80ac01bc30f: Remove deleting cxx files after build (authored by • InkaSokolowska). · Explain WhyOct 14 2022, 1:02 AM
This revision was automatically updated to reflect the committed changes.
• InkaSokolowska added a commit: rCOMMd80ac01bc30f: Remove deleting cxx files after build.
tomek added a comment.Oct 14 2022, 2:45 AM

Looking at the diff that introduced this D5168 it seems like the main reason was to

remove the header files after build so they don't appear in the devs' git status

Should we git ignore the files then?

inka added a comment.Oct 14 2022, 3:28 AM

@tomek the files are .gitignored in this .gitignore

Revision Contents
Changeset List

PathSize
native/
ios/
Comm.xcodeproj/
20 lines

Diff 17503

View Options

native/ios/Comm.xcodeproj/project.pbxproj

Loading...