[native] more refactoring of the native rust library
ClosedPublic
Actions

Authored by varun on Sep 16 2022, 2:56 PM.

Details

Reviewers

ashoat
• jon

Commits

rCOMM3b94e3aedfd1: [native] more refactoring of the native rust library

Summary

remove the header files after build so they don't appear in the devs' git status. also rename grpc_client -> native_rust_library and move it out of the cpp folder. we're renaming the cargo project because it will be more than a gRPC client library going forward.

Depends on D5104

Test Plan

cleaned the Xcode build folder, removed all build artifacts from git repo with cargo clean, deleted the header files, and then ran Xcode build

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

varun created this revision.Sep 16 2022, 2:56 PM

Herald added subscribers: • abosh, ashoat. · View Herald TranscriptSep 16 2022, 2:56 PM

Harbormaster completed remote builds in B12233: Diff 16782.Sep 16 2022, 3:06 PM

varun requested review of this revision.Sep 16 2022, 3:06 PM

varun edited the summary of this revision. (Show Details)Sep 16 2022, 3:13 PM

varun added subscribers: inka, marcin.Sep 16 2022, 3:34 PM

varun added inline comments.Sep 16 2022, 3:52 PM

.gitignore
11 ↗	(On Diff #16782)	created a separate .gitignore file for the cargo project
native/cpp/CommonCpp/grpc/grpc_client/cxx.h
1 ↗	(On Diff #16782)	we don't need to check this file in anymore, since we're creating it in the Xcode build and deleting it in the last build phase. same with the other header file
native/native_rust_library/.gitignore
1 ↗	(On Diff #16782)	it's easier to just have a separate .gitignore for the cargo project in case we move the folder to a new location in the future
scripts/clean-up-native-rust-library.sh
1–3 ↗	(On Diff #16782)	addresses @jon 's feedback on previous diff in stack

ashoat accepted this revision.Sep 16 2022, 4:32 PM

ashoat added inline comments.

native/cpp/CommonCpp/grpc/grpc_client/cxx.h
1 ↗	(On Diff #16782)	we're creating it in the Xcode build and deleting it in the last build phase Where exactly does this change occur? Can't tell if there's something in the `.pbxproj` or what
scripts/clean-up-native-rust-library.sh
1 ↗	(On Diff #16782)	Newline after shebang

varun added inline comments.Sep 16 2022, 4:39 PM

native/cpp/CommonCpp/grpc/grpc_client/cxx.h
1 ↗	(On Diff #16782)	the files are generated in `scripts/build-rust-native-library.sh` (previous diff in stack) and they're deleted in `scripts/clean-up-native-rust-library.sh`. these scripts are being called in Xcode Build Phases (you can see it in `project.pbxproj` lines 895 and 914)
scripts/clean-up-native-rust-library.sh
1 ↗	(On Diff #16782)	ack