Page MenuHomePhabricator

Remove deleting cxx files after build
ClosedPublic

Authored by inka on Oct 12 2022, 2:10 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Dec 3, 3:41 PM
Unknown Object (File)
Wed, Nov 27, 9:06 PM
Unknown Object (File)
Tue, Nov 26, 5:07 PM
Unknown Object (File)
Mon, Nov 25, 10:35 PM
Unknown Object (File)
Mon, Nov 25, 10:35 PM
Unknown Object (File)
Mon, Nov 25, 10:35 PM
Unknown Object (File)
Nov 15 2024, 6:23 AM
Unknown Object (File)
Nov 15 2024, 6:23 AM

Details

Summary

linear issue: ENG-2013
Deleting lib.rs.h, lib.rs.cc and cxx.h after build causes IDE to display errors, and to be unable to index our cxx functions.
These files are in .gitignore, so this should only change what is seen locally.

Test Plan

Build ios, stop ios, see that lib.rs.h, lib.rs.cc and cxx.h files are still present in native/native-rust_library/

Diff Detail

Repository
rCOMM Comm
Branch
inka/remove_deleting_cxx_files
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

inka requested review of this revision.Oct 12 2022, 2:19 AM

let's remove the clean-up-native-rust-library.sh script as well since we're not calling it anymore

This revision is now accepted and ready to land.Oct 13 2022, 8:18 AM

remove clean-up-native-rust-library.sh

Looking at the diff that introduced this D5168 it seems like the main reason was to

remove the header files after build so they don't appear in the devs' git status

Should we git ignore the files then?