Paths

Table of Contentst

Differential D5372

[lib] moved modal-provider.react from web to lib
ClosedPublic
Actions

Authored by ginsu on Oct 14 2022, 8:28 AM.

Tags

None

Referenced Files

	F3757047: D5372.id17581.diff
	Fri, Jan 10, 7:02 AM

	F3755267: D5372.diff
	Fri, Jan 10, 4:09 AM

	Unknown Object (File)
	Sun, Jan 5, 4:39 PM

	Unknown Object (File)
	Sun, Jan 5, 4:39 PM

	Unknown Object (File)
	Sun, Jan 5, 4:39 PM

	Unknown Object (File)
	Sun, Jan 5, 4:33 PM

	Unknown Object (File)
	Nov 28 2024, 11:32 PM

	Unknown Object (File)
	Nov 25 2024, 10:37 PM

Subscribers

Details

Reviewers

atul
• abosh
rohan
• przemek

Commits

rCOMMb75a8dec8023: [lib] moved modal-provider.react from web to lib

Summary

moved modal-provider.react from web to lib. Also needed to change all the imports calls of modal-provider.react to use lib instead of web

Depends on D5370
Linear Task: ENG-2038

Test Plan

Please watch the video to see that there are no visual or performance regressions witht the migration of modal-provider.react from web to lib. Also everything compiles successfully which is a
good indication that all the imports have been correclty refactored

Diff Detail

Repository

Branch

arcpatch-D5364 (branched from master)

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ginsu created this revision.Oct 14 2022, 8:28 AM

Herald added subscribers: • abosh, atul, tomek, ashoat. · View Herald TranscriptOct 14 2022, 8:28 AM

ginsu edited the summary of this revision. (Show Details)Oct 14 2022, 8:32 AM

ginsu edited the test plan for this revision. (Show Details)

ginsu added reviewers: atul, • abosh, rohan, • przemek.

ginsu added a parent revision: D5370: [lib] moved ModalOverlay component from web to lib.

Harbormaster completed remote builds in B12804: Diff 17581.Oct 14 2022, 8:38 AM

ginsu requested review of this revision.Oct 14 2022, 8:38 AM

Ok

ginsu attached a referenced file: F199327: Screen Recording 2022-10-14 at 11.20.04 AM.mov. (Show Details)Oct 14 2022, 11:58 AM

👍🏽

This revision is now accepted and ready to land.Oct 14 2022, 12:20 PM

Closed by commit rCOMMb75a8dec8023: [lib] moved modal-provider.react from web to lib (authored by ginsu). · Explain WhyOct 14 2022, 12:24 PM

This revision was automatically updated to reflect the committed changes.

ginsu added a commit: rCOMMb75a8dec8023: [lib] moved modal-provider.react from web to lib.

Revision Contents
Changeset List

Path

Size

	lib/	components/
	web/	modals/

modal-provider.react.js

2 lines

web/

account/

log-in-form.react.js

2 lines

5 lines

calendar/

2 lines

2 lines

filter-panel.react.js

2 lines

chat/

chat-thread-list-see-more-sidebars.react.js

2 lines

thread-menu.react.js

2 lines

input/

input-state-container.react.js

2 lines

media/

multimedia-modal.react.js

3 lines

multimedia.react.js

3 lines

modals/

account/

log-in-first-modal.react.js

3 lines

log-in-modal.react.js

3 lines

3 lines

concurrent-modification-modal.react.js

3 lines

history/

history-modal.react.js

2 lines

modal-provider.react.js

threads/

members/

members-modal.react.js

2 lines

settings/

thread-settings-delete-tab.react.js

2 lines

thread-settings-modal.react.js

2 lines

thread-settings-privacy-tab.react.js

2 lines

sidebars/

sidebar.react.js

2 lines

subchannels/

subchannel.react.js

2 lines

settings/

account-delete-modal.react.js

2 lines

account-settings.react.js

2 lines

danger-zone.react.js

3 lines

password-change-modal.js

2 lines

relationship/

block-list-modal.react.js

2 lines

friend-list-modal.react.js

2 lines

Diff 17581

lib/components/modal-provider.react.js

Loading...

web/account/log-in-form.react.js

Loading...

web/app.react.js

Loading...

web/calendar/day.react.js

Loading...

web/calendar/entry.react.js

Loading...

web/calendar/filter-panel.react.js

Loading...

web/chat/chat-thread-list-see-more-sidebars.react.js

Loading...

web/chat/thread-menu.react.js

Loading...

web/input/input-state-container.react.js

Loading...

web/media/multimedia-modal.react.js

Loading...

web/media/multimedia.react.js

Loading...

web/modals/account/log-in-first-modal.react.js

Loading...

web/modals/account/log-in-modal.react.js

Loading...

web/modals/alert.react.js

Loading...

web/modals/concurrent-modification-modal.react.js

Loading...

web/modals/history/history-modal.react.js

Loading...

web/modals/modal-provider.react.js

Loading...

web/modals/threads/members/members-modal.react.js

Loading...

web/modals/threads/settings/thread-settings-delete-tab.react.js

Loading...

web/modals/threads/settings/thread-settings-modal.react.js

Loading...

web/modals/threads/settings/thread-settings-privacy-tab.react.js

Loading...

web/modals/threads/sidebars/sidebar.react.js

Loading...

web/modals/threads/subchannels/subchannel.react.js

Loading...

web/settings/account-delete-modal.react.js

Loading...

web/settings/account-settings.react.js

Loading...

web/settings/danger-zone.react.js

Loading...

web/settings/password-change-modal.js

Loading...

web/settings/relationship/block-list-modal.react.js

Loading...

web/settings/relationship/friend-list-modal.react.js

Loading...