Paths

Table of Contentst

Differential D5380

[services] Tunnelbroker - Unifying paths in Docker according to the local repository
ClosedPublic
Actions

Authored by • max on Oct 17 2022, 7:08 AM.

Tags

None

Referenced Files

	F2905369: D5380.diff
	Sun, Oct 6, 4:55 AM

	Unknown Object (File)
	Wed, Oct 2, 11:09 AM

	Unknown Object (File)
	Thu, Sep 26, 9:38 PM

	Unknown Object (File)
	Sat, Sep 7, 2:55 AM

	Unknown Object (File)
	Sat, Sep 7, 2:55 AM

	Unknown Object (File)
	Sat, Sep 7, 2:55 AM

	Unknown Object (File)
	Sat, Sep 7, 2:49 AM

	Unknown Object (File)
	Fri, Sep 6, 11:41 PM

Subscribers

Details

Reviewers

• jon
varun
marcin
tomek

Commits

rCOMM0f2b7c8a169b: [services] Tunnelbroker - Unifying paths in Docker according to the local…

Summary

This diff introduces changes to unify source paths according to the repository. These changes are required to remove the conditional paths includes in CMake and simplify future includes into the Cargo build.rs file as long as unifies the directory structure.

This diff also includes some minor prettifying to the CMakeLists and Dockerfile and removing unused commands from them.

Related Linear task: ENG-2044

Test Plan

The service was successfully built in Docker and Nix dev environments.

Diff Detail

Repository

Branch

unify-paths

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• max created this revision.Oct 17 2022, 7:08 AM

• max held this revision as a draft.

Herald added a reviewer: • jon. · View Herald TranscriptOct 17 2022, 7:08 AM

Herald added subscribers: • abosh, atul, tomek, ashoat. · View Herald Transcript

• max edited the summary of this revision. (Show Details)Oct 17 2022, 7:13 AM

• max edited the test plan for this revision. (Show Details)

• max added reviewers: varun, marcin. • max added 1 blocking reviewer(s): • jon.

• max edited the summary of this revision. (Show Details)

Harbormaster completed remote builds in B12828: Diff 17613.Oct 17 2022, 7:19 AM

• max published this revision for review.Oct 17 2022, 7:19 AM

• max added a child revision: D5360: [services] Tunnelbroker - Add protobuf file compilation to Cargo `build.rs`.Oct 17 2022, 8:06 AM

LGTM

This revision is now accepted and ready to land.Oct 18 2022, 10:17 AM

• max added a reviewer: tomek.Oct 20 2022, 1:46 AM

This revision now requires review to proceed.Oct 20 2022, 1:46 AM

Adding @tomek as blocking.

tomek accepted this revision.Oct 20 2022, 6:57 AM

This revision is now accepted and ready to land.Oct 20 2022, 6:57 AM

Closed by commit rCOMM0f2b7c8a169b: [services] Tunnelbroker - Unifying paths in Docker according to the local… (authored by • max). · Explain WhyOct 21 2022, 9:15 AM

This revision was automatically updated to reflect the committed changes.

• max added a commit: rCOMM0f2b7c8a169b: [services] Tunnelbroker - Unifying paths in Docker according to the local….

• max removed a child revision: D5360: [services] Tunnelbroker - Add protobuf file compilation to Cargo `build.rs`.Oct 24 2022, 10:15 AM

Revision Contents
Changeset List

Path

Size

services/

tunnelbroker/

54 lines

50 lines

Diff 17613

services/tunnelbroker/CMakeLists.txt

Loading...

services/tunnelbroker/Dockerfile

Loading...