Details

Reviewers

atul
rohan
ashoat

Commits

rCOMM453681b6535c: [landing] populated the investor data

Summary

populated the investor data into a file called investor-data.js. This diff is just the addition of this file, the actual population of the investor data into the InvestorProfile components will come in a separate diff. Ranjan Pradeep is not on the list, since he does not have any info yet, but we can add him later in a separate diff once we have his information

Linear Task: ENG-1505
Investor Slides: Canva

Test Plan

Please view the screenshot to see an example of the data being populated into the InvestorCard components:

Screen Shot 2022-10-18 at 1.49.59 PM.png (2×3 px, 2 MB)

Diff Detail

Repository

rCOMM Comm

Branch

eng-1953 (branched from master)

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ginsu created this revision.Oct 18 2022, 10:57 AM

Herald added subscribers: • abosh, atul, tomek, ashoat. · View Herald TranscriptOct 18 2022, 10:57 AM

Harbormaster returned this revision to the author for changes because remote builds failed.Oct 18 2022, 11:00 AM

Harbormaster failed remote builds in B12848: Diff 17638!

removed some code to test UI of investor data

ginsu edited the summary of this revision. (Show Details)Oct 18 2022, 11:03 AM

ginsu edited the test plan for this revision. (Show Details)

ginsu added reviewers: atul, rohan.

ginsu attached a referenced file: F202647: Screen Shot 2022-10-18 at 1.49.59 PM.png. (Show Details)

Harbormaster returned this revision to the author for changes because remote builds failed.Oct 18 2022, 11:04 AM

Harbormaster failed remote builds in B12849: Diff 17639!

fixed classnames dependency name

just making files changed the investor-data.js

Harbormaster completed remote builds in B12850: Diff 17640.Oct 18 2022, 11:28 AM

Harbormaster completed remote builds in B12851: Diff 17641.Oct 18 2022, 11:37 AM

ginsu requested review of this revision.Oct 18 2022, 11:37 AM

ginsu edited the summary of this revision. (Show Details)Oct 18 2022, 11:38 AM

fixed Liu Jiang's name

rohan requested changes to this revision.Oct 18 2022, 11:42 AM

rohan added inline comments.

landing/investor-data.js
5–11 ↗	(On Diff #17642)	Would it be best to define the read-only properties in the type, similar to how we do it here: https://github.com/CommE2E/comm/blob/master/lib/facts/testers.js Something like type Investors = { +id: string, +name: string, +description: string, +investmentDate?: string, +imageURL: string, }; Probably defer to @atul though

This revision now requires changes to proceed.Oct 18 2022, 11:42 AM

made types read only

changed investmentDate to invovlementDate

Harbormaster completed remote builds in B12852: Diff 17642.Oct 18 2022, 11:51 AM

Harbormaster completed remote builds in B12853: Diff 17643.

Harbormaster completed remote builds in B12854: Diff 17644.Oct 18 2022, 12:02 PM

This looks good to me... I know I suggested involvementDate but maybe involvement would make more sense since it includes [joined/advisor since/investor since] as well as when the individual got involved.

Adding @ashoat as blocking reviewer since there's user facing copy

ashoat added inline comments.Oct 18 2022, 1:19 PM

landing/investor-data.js
18 ↗	(On Diff #17644)	This text feels a bit self-aggrandizing but maybe that's what we want (I think Lara wrote it). Probably worth replacing "Sole Founder and CEO" with just "Founder", at least.