[IGNORE][CommCoreModule] `ROLLBACK` transaction on migration failure
AbandonedPublic
Actions

Authored by atul on Oct 20 2022, 8:58 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Apr 10, 7:36 AM

	Unknown Object (File)
	Wed, Apr 9, 3:38 AM

	Unknown Object (File)
	Wed, Apr 9, 3:38 AM

	Unknown Object (File)
	Wed, Apr 9, 3:38 AM

	Unknown Object (File)
	Sun, Apr 6, 5:38 AM

	Unknown Object (File)
	Fri, Mar 28, 5:15 PM

	Unknown Object (File)
	Mar 15 2025, 8:48 PM

	Unknown Object (File)
	Mar 14 2025, 9:41 PM

Subscribers

Details

Reviewers

kamil
• jon

Summary

Test Plan

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Oct 20 2022, 8:58 AM

Herald added a reviewer: • jon. · View Herald TranscriptOct 20 2022, 8:58 AM

Herald added subscribers: • abosh, tomek, ashoat. · View Herald Transcript

atul added a child revision: D5441: [IGNORE][CommCoreModule] `ROLLBACK` if migration idx <= db_version_inside_transaction.Oct 20 2022, 8:59 AM

atul published this revision for review.Oct 20 2022, 9:00 AM

atul mentioned this in D5377: [native/sqlite] refactor code to perform migration inside one transaction.

Harbormaster failed remote builds in B12934: Diff 17733!Oct 20 2022, 9:05 AM

Harbormaster completed remote builds in B12934: Diff 17733.Oct 20 2022, 10:36 AM

looks fine to me, but let someone else more familiar with the sqlite logic to do approval

This was only ever meant as a demonstration

Revision Contents
Changeset List

Path

Size

native/

cpp/

CommonCpp/

DatabaseManagers/

SQLiteQueryExecutor.cpp

3 lines

Diff 17733

View Options

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp

[IGNORE][CommCoreModule] `ROLLBACK` transaction on migration failureAbandonedPublicActions