Differential D5441

[IGNORE][CommCoreModule] `ROLLBACK` if migration idx <= db_version_inside_transaction
AbandonedPublic
Actions

Authored by atul on Oct 20 2022, 8:59 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Mar 28, 12:49 PM

	Unknown Object (File)
	Sat, Mar 15, 8:48 PM

	Unknown Object (File)
	Fri, Mar 14, 5:56 PM

	Unknown Object (File)
	Thu, Mar 13, 12:01 AM

	Unknown Object (File)
	Tue, Mar 11, 7:30 AM

	Unknown Object (File)
	Feb 17 2025, 6:45 PM

	Unknown Object (File)
	Feb 17 2025, 6:45 PM

	Unknown Object (File)
	Feb 17 2025, 6:43 PM

Subscribers

Details

Reviewers

kamil
• jon

Summary

NA

Depends on D5440

Test Plan

NA

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Oct 20 2022, 8:59 AM

Herald added a reviewer: • jon. · View Herald TranscriptOct 20 2022, 8:59 AM

Herald added subscribers: • abosh, tomek, ashoat. · View Herald Transcript

atul published this revision for review.Oct 20 2022, 9:00 AM

atul mentioned this in D5377: [native/sqlite] refactor code to perform migration inside one transaction.

Harbormaster failed remote builds in B12935: Diff 17734!Oct 20 2022, 9:05 AM

Harbormaster completed remote builds in B12935: Diff 17734.Oct 20 2022, 10:40 AM

• jon added inline comments.Oct 21 2022, 12:01 PM

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp
570–572	seems a little odd to me, lines 557-559 should iterate to the next applicable migration. This logic seems like it would be really error prone and a source of constant pain later on.

This was only ever meant as a demonstration

Revision Contents
Changeset List

Path

Size

native/

cpp/

CommonCpp/

DatabaseManagers/

SQLiteQueryExecutor.cpp

8 lines

Diff 17734

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp

	Show All 34 Lines		const bridge: ElectronBridge = {
	},			},
	onNotificationClicked: callback => {			onNotificationClicked: callback => {
	const withEvent = (event: IpcRendererEvent, ...args: $ReadOnlyArray<any>) =>			const withEvent = (event: IpcRendererEvent, ...args: $ReadOnlyArray<any>) =>
	callback(...args);			callback(...args);
	ipcRenderer.on('on-notification-clicked', withEvent);			ipcRenderer.on('on-notification-clicked', withEvent);
	return () =>			return () =>
	ipcRenderer.removeListener('on-notification-clicked', withEvent);			ipcRenderer.removeListener('on-notification-clicked', withEvent);
	},			},
				fetchDeviceToken: () => ipcRenderer.send('fetch-device-token'),
	};			};

	contextBridge.exposeInMainWorld('electronContextBridge', bridge);			contextBridge.exposeInMainWorld('electronContextBridge', bridge);