Differential D5441

[IGNORE][CommCoreModule] `ROLLBACK` if migration idx <= db_version_inside_transaction
AbandonedPublic
Actions

Authored by atul on Oct 20 2022, 3:59 PM.

Tags

None

Referenced Files

None

Subscribers

Details

Reviewers

kamil
• jon

Summary

NA

Depends on D5440

Test Plan

NA

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Oct 20 2022, 3:59 PM

Herald added a reviewer: • jon. · View Herald TranscriptOct 20 2022, 3:59 PM

Herald added subscribers: • abosh, tomek, ashoat. · View Herald Transcript

atul published this revision for review.Oct 20 2022, 4:00 PM

atul mentioned this in D5377: [native/sqlite] refactor code to perform migration inside one transaction.

Harbormaster failed remote builds in B12935: Diff 17734!Oct 20 2022, 4:05 PM

Harbormaster completed remote builds in B12935: Diff 17734.Oct 20 2022, 5:40 PM

• jon added inline comments.Oct 21 2022, 7:01 PM

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp
570–572	seems a little odd to me, lines 557-559 should iterate to the next applicable migration. This logic seems like it would be really error prone and a source of constant pain later on.

This was only ever meant as a demonstration

Revision Contents
Changeset List

Path

Size

native/

cpp/

CommonCpp/

DatabaseManagers/

SQLiteQueryExecutor.cpp

8 lines

Diff 17734

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp

Loading...