Page MenuHomePhabricator
Differential D5441

[IGNORE][CommCoreModule] `ROLLBACK` if migration idx <= db_version_inside_transaction
AbandonedPublic
Actions

Authored by atul on Oct 20 2022, 8:59 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 9, 3:38 AM
Unknown Object (File)
Wed, Apr 9, 3:38 AM
Unknown Object (File)
Wed, Apr 9, 3:38 AM
Unknown Object (File)
Thu, Apr 3, 10:46 PM
Unknown Object (File)
Fri, Mar 28, 12:49 PM
Unknown Object (File)
Mar 15 2025, 8:48 PM
Unknown Object (File)
Mar 14 2025, 5:56 PM
Unknown Object (File)
Mar 13 2025, 12:01 AM
View All Files
Subscribers
• abosh
ashoat
tomek

Details

Reviewers
kamil
• jon
Summary

NA

Depends on D5440

Test Plan

NA

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul created this revision.Oct 20 2022, 8:59 AM
Herald added a reviewer: • jon. · View Herald TranscriptOct 20 2022, 8:59 AM
Herald added subscribers: • abosh, tomek, ashoat. · View Herald Transcript
atul published this revision for review.Oct 20 2022, 9:00 AM
atul mentioned this in D5377: [native/sqlite] refactor code to perform migration inside one transaction.
Harbormaster failed remote builds in B12935: Diff 17734!Oct 20 2022, 9:05 AM
Harbormaster completed remote builds in B12935: Diff 17734.Oct 20 2022, 10:40 AM
• jon added inline comments.Oct 21 2022, 12:01 PM
native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp
570–572

seems a little odd to me, lines 557-559 should iterate to the next applicable migration.

This logic seems like it would be really error prone and a source of constant pain later on.

atul abandoned this revision.Oct 26 2022, 3:01 PM

This was only ever meant as a demonstration

Revision Contents
Changeset List

PathSize
native/
cpp/
CommonCpp/
DatabaseManagers/
8 lines

Diff 17734

View Options

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp

Show All 11 Lines
type RustAPI = { type RustAPI = {
+registerUser: ( +registerUser: (
userId: string, userId: string,
deviceId: string, deviceId: string,
username: string, username: string,
password: string, password: string,
userPublicKey: string, userPublicKey: string,
) => Promise<string>, ) => Promise<string>,
+deleteUser: (userId: string) => Promise<boolean>,
}; };
async function getRustAPI(): Promise<RustAPI> { async function getRustAPI(): Promise<RustAPI> {
let nativeBinding = null; let nativeBinding = null;
if (platform === 'darwin' && arch === 'x64') { if (platform === 'darwin' && arch === 'x64') {
// $FlowFixMe // $FlowFixMe
nativeBinding = require('./napi/rust-node-addon.darwin-x64.node'); nativeBinding = require('./napi/rust-node-addon.darwin-x64.node');
} else if (platform === 'darwin' && arch === 'arm64') { } else if (platform === 'darwin' && arch === 'arm64') {
// $FlowFixMe // $FlowFixMe
nativeBinding = require('./napi/rust-node-addon.darwin-arm64.node'); nativeBinding = require('./napi/rust-node-addon.darwin-arm64.node');
} else if (platform === 'linux' && arch === 'x64') { } else if (platform === 'linux' && arch === 'x64') {
// $FlowFixMe // $FlowFixMe
nativeBinding = require('./napi/rust-node-addon.linux-x64-gnu.node'); nativeBinding = require('./napi/rust-node-addon.linux-x64-gnu.node');
} else if (platform === 'linux' && arch === 'arm64') { } else if (platform === 'linux' && arch === 'arm64') {
// $FlowFixMe // $FlowFixMe
nativeBinding = require('./napi/rust-node-addon.linux-arm64-gnu.node'); nativeBinding = require('./napi/rust-node-addon.linux-arm64-gnu.node');
} else { } else {
throw new Error(`Unsupported OS: ${platform}, architecture: ${arch}`); throw new Error(`Unsupported OS: ${platform}, architecture: ${arch}`);
} }
if (!nativeBinding) { if (!nativeBinding) {
throw new Error('Failed to load native binding'); throw new Error('Failed to load native binding');
} }
const { registerUser } = nativeBinding; const { registerUser, deleteUser } = nativeBinding;
return { registerUser }; return { registerUser, deleteUser };
} }
export { getRustAPI }; export { getRustAPI };