Page MenuHomePhabricator
Differential D5455

[yarn] Rename `yarn patch` to `yarn arcpatch`
ClosedPublic
Actions

Authored by atul on Oct 21 2022, 11:09 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 24, 4:01 PM
Unknown Object (File)
Mon, Apr 21, 9:18 AM
Unknown Object (File)
Mon, Apr 21, 3:11 AM
Unknown Object (File)
Sun, Apr 20, 10:34 PM
Unknown Object (File)
Sun, Apr 20, 10:30 PM
Unknown Object (File)
Sun, Apr 20, 1:06 AM
Unknown Object (File)
Wed, Apr 9, 3:47 AM
Unknown Object (File)
Wed, Apr 9, 3:47 AM
View All Files
Subscribers
• abosh
ashoat
tomek

Details

Reviewers
varun
tomek
ginsu
Commits
rCOMMb1f7ecdc14c7: [yarn] Rename `yarn patch` to `yarn arcpatch`
Summary

Addresses point made by @tomek here: https://phab.comm.dev/D5445#inline-35863

Test Plan

Continues to work as expected... straightforward rename

Diff Detail

Repository
rCOMM Comm
Branch
arcpatch-D5455 (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul created this revision.Oct 21 2022, 11:09 AM
Herald added subscribers: • abosh, ashoat. · View Herald TranscriptOct 21 2022, 11:09 AM
atul edited the summary of this revision. (Show Details)Oct 21 2022, 11:10 AM
atul mentioned this in D5445: [yarn] Add `yarn patch` command to `package.json`.
Harbormaster returned this revision to the author for changes because remote builds failed.Oct 21 2022, 11:18 AM
Harbormaster failed remote builds in B12970: Diff 17816!
atul requested review of this revision.Oct 21 2022, 11:32 AM
varun accepted this revision.Oct 21 2022, 11:32 AM
This revision is now accepted and ready to land.Oct 21 2022, 11:32 AM
atul updated this revision to Diff 17820.Oct 21 2022, 11:37 AM

rebase before landing

This revision was landed with ongoing or failed builds.Oct 21 2022, 11:37 AM
Closed by commit rCOMMb1f7ecdc14c7: [yarn] Rename `yarn patch` to `yarn arcpatch` (authored by atul). · Explain Why
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMMb1f7ecdc14c7: [yarn] Rename `yarn patch` to `yarn arcpatch`.
Harbormaster completed remote builds in B12970: Diff 17816.Oct 21 2022, 11:39 AM
Harbormaster completed remote builds in B12973: Diff 17820.Oct 21 2022, 11:49 AM

Revision Contents
Changeset List

PathSize
2 lines

Diff 17820

View Options

package.json

  • This file was added.
// @flow
import { createDrawerNavigator } from '@react-navigation/drawer';
import * as React from 'react';
import { Dimensions, View } from 'react-native';
import { useStyles } from '../themes/colors';
import type { AppNavigationProp } from './app-navigator.react';
import CommunityDrawerContent from './community-drawer-content.react';
import { TabNavigatorRouteName } from './route-names';
import type { NavigationRoute } from './route-names';
import TabNavigator from './tab-navigator.react';
const Drawer = createDrawerNavigator();
const communityDrawerContent = () => <CommunityDrawerContent />;
type Props = {
+navigation: AppNavigationProp<'CommunityDrawerNavigator'>,
+route: NavigationRoute<'CommunityDrawerNavigator'>,
};
// eslint-disable-next-line no-unused-vars
function CommunityDrawerNavigator(props: Props): React.Node {
const styles = useStyles(unboundStyles);
const screenOptions = React.useMemo(
() => ({
drawerStyle: styles.drawerStyle,
}),
[styles.drawerStyle],
);
return (
<View style={styles.drawerView}>
<Drawer.Navigator
screenOptions={screenOptions}
drawerContent={communityDrawerContent}
tomekUnsubmitted
Not Done
Inline Actions
screenOptions={screenOptions}
- drawerContent={communityDrawerContent}
+ drawerContent={CommunityDrawerContent}
>
<Drawer.Screen name={TabNavigatorRouteName} component={TabNavigator} />

Are we sure that Flow doesn't allow us to use CommunityDrawerContent directly? Ultimately, it is a function that doesn't take arguments, so it should be possible to use here (but maybe Flow disagrees with that).

tomek: Are we sure that Flow doesn't allow us to use `CommunityDrawerContent` directly? Ultimately, it…
inkaAuthorUnsubmitted
Done
Inline Actions

Flow doesn't allow that. It says that React.ComponentType is incompatible with function type.
React.ComponentType comes from the memoization of CommunityDrawerContent

inka: Flow doesn't allow that. It says that `React.ComponentType is incompatible with function type`.
>
<Drawer.Screen name={TabNavigatorRouteName} component={TabNavigator} />
</Drawer.Navigator>
</View>
);
}
const unboundStyles = {
drawerView: {
flex: 1,
},
drawerStyle: {
width: Dimensions.get('window').width - 36,
ashoatUnsubmitted
Not Done
Inline Actions

Following ENG-2413 getting cancelled, we should remove this. Mentioning here because there is no longer a Linear task tracking the removal

ashoat: Following [ENG-2413](https://linear.app/comm/issue/ENG-2413/use-a-hook-in-drawer-navigator-for…
},
};
export { CommunityDrawerNavigator };