[Nix] Unpin nodejs v16
ClosedPublic
Actions

Authored by • jon on Oct 24 2022, 8:01 AM.

Details

Reviewers

atul
varun

Group Reviewers

Restricted Owners Package

(Owns No Changed Paths)

Commits

rCOMMaf411e03c90a: [Nix] Unpin nodejs v16

Summary

Need for pinning node is no longer relevant, allow for the latest
node v16 to be available by default.

Test Plan

nix develop

# start `yarn dev` for web scenarios
(cd landing &&  yarn dev &)
(cd web &&  yarn dev &)
(cd keyserver &&  yarn dev &)

# visit local comm instance
open http://localhost:3000/commlanding

# cleanup background processes
kill %%
kill %%
kill %%

Diff Detail

Repository

rCOMM Comm

Branch

jonringer/unpin-node

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• jon created this revision.Oct 24 2022, 8:01 AM

Owners added a reviewer: Restricted Owners Package.Oct 24 2022, 8:01 AM

Herald added subscribers: • abosh, tomek, ashoat. · View Herald TranscriptOct 24 2022, 8:01 AM

Harbormaster returned this revision to the author for changes because remote builds failed.Oct 24 2022, 8:10 AM

Harbormaster failed remote builds in B12992: Diff 17851!

Harbormaster completed remote builds in B12992: Diff 17851.Oct 24 2022, 9:39 AM

• jon requested review of this revision.Oct 24 2022, 9:39 AM

Wasn't super thorough, but made sure that I could get keyserver/web/landing running and clicked around web app and landing page to check that they seemed to work as expected

This revision is now accepted and ready to land.Oct 24 2022, 9:56 AM

Closed by commit rCOMMaf411e03c90a: [Nix] Unpin nodejs v16 (authored by • jon). · Explain WhyOct 24 2022, 3:21 PM

This revision was automatically updated to reflect the committed changes.

• jon added a commit: rCOMMaf411e03c90a: [Nix] Unpin nodejs v16.