[Nix Docs] Add section about JDK for Android Studio
AbandonedPublic
Actions

Authored by • jon on Nov 7 2022, 8:49 AM.

Details

Reviewers

varun
ashoat

Summary

Android Studio will require a JDK installation. Although JDK is
provided by nix develop, it is not accessible to Android Studio outside of
the nix development shell.

Include instructions to nix documentation on how to install the JDK using
sdkman to provide a JDK installation at a stable path.

Test Plan

N/A, mostly copied from existing documentation sources.

Diff Detail

Repository

rCOMM Comm

Branch

jonringer/nix-docs-jdk

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• jon created this revision.Nov 7 2022, 8:49 AM

Herald added subscribers: • abosh, atul, tomek. · View Herald TranscriptNov 7 2022, 8:49 AM

Harbormaster returned this revision to the author for changes because remote builds failed.Nov 7 2022, 9:04 AM

Harbormaster failed remote builds in B13221: Diff 18145!

Rebase on top of master

Harbormaster completed remote builds in B13368: Diff 18330.Nov 10 2022, 10:08 AM

• jon requested review of this revision.Nov 10 2022, 10:08 AM

This diff copy-pastes something and then changes it, which makes it hard to review the changes. See here

Can you either split it up into two diffs, or at least annotate clearly what's been changed so your reviewers know what to review?

docs/nix_mobile_setup.md
69 ↗	(On Diff #18330)	Capitalize `Nix`

This revision now requires changes to proceed.Nov 10 2022, 1:36 PM

ashoat mentioned this in D5624: [docs] Copy JDK docs into Nix.Nov 13 2022, 10:08 AM

ashoat commandeered this revision.Nov 13 2022, 10:34 AM

ashoat edited reviewers, added: • jon; removed: ashoat.

This revision now requires review to proceed.Nov 13 2022, 10:34 AM

Herald added 1 blocking reviewer(s): • jon. · View Herald TranscriptNov 13 2022, 10:34 AM

Rebase on D5624

ashoat added a parent revision: D5624: [docs] Copy JDK docs into Nix.Nov 13 2022, 10:35 AM

ashoat foisted this revision upon • jon.

ashoat edited reviewers, added: ashoat; removed: • jon.

We have a new intern starting on Monday, and I wanted to get the Nix docs updated before then in case he wanted to try them out. I went ahead and separated out the copy-pasted parts (into D5624) as requested in my last comment, and also tidied up the structure (in D5625). This diff is now just the changes, following the "Move code around" doc. Passing back to Jon with suggestions on his edits