Do we really need to introduce spoilerIsBlockingTooltip here, or can we just pass spoilerPressActive directly into spoilerIsBlockingTooltip prop of TextMessage component?

If I understand correctly the outer [key: string] is for messageID and the inner [key: number] is for the spoiler identifier, is that right?

Can we use useMemo instead so we don't have to imperatively update styleBasedOnState with setStyleBasedOnState?

Hm this doesn't seem quite right that we're early returning based on the value of a style?

We don't want to be storing the style in a useState like this... we'll want to compute the style based on state.

We don't want to be using styles like this in our logic... styles should just be a function of the state.

We should explicitly introduce state that captures what we're trying to use styleBasedOnState for. But we shouldn't use styleBasedOnState since styling is a "side-effect" of state... not the actual state

Yeah we don't want to be imperatively setting styles like this. We should set the dependencies and let it be computed declaratively

Hm, there's got to be a better way to handle this. I'm afraid that if parsedSpoilerIdentifier is ever actually set to -1 it would lead to strange behavior. Let's leave this as is... but can we create a Linear task or something to see if we can handle this case more gracefully?

Do we need to keep track of this with useState or can we just use spoilerRevealed?.[messageID]?.[parsedSpoilerIdentifier] ?? false and setSpoilerRevealed directly?

We can still pull spoilerRevealed?.[messageID]?.[parsedSpoilerIdentifier] ?? false out into a variable called isRevealed or something

eg

const isRevealed = spoilerRevealed?.[messageID]?.[parsedSpoilerIdentifier] ?? false;

but I don't think we need to use useState and don't really have much use for setIsRevealed

With

const isRevealed = spoilerRevealed?.[messageID]?.[parsedSpoilerIdentifier] ?? false;

isRevealed will recompute when spoilerRevealed is updated.

Any change in markdownContext?.spoilerRevealed should trigger everything below in the component tree to get recomputed: https://blog.isquaredsoftware.com/2020/05/blogged-answers-a-mostly-complete-guide-to-react-rendering-behavior/#context-and-rendering-behavior

Is this not inline with the behavior you're observing?

In what scenario will markdownContext not be defined? If there is no such scenario, please add an invariant and remove all conditions (eg. the optional chaining here, the first two conditions in the if statement on lines 48-53, etc.)