Paths

Table of Contentst

[native] Avoid hardcoding path to rust_native_library lib.rs.h file
ClosedPublic
Actions

Authored by ashoat on Nov 10 2022, 12:41 PM.

Details

Reviewers

varun
• jon
• max

Commits

rCOMMf7a17e3c25fa: [native] Avoid hardcoding path to rust_native_library lib.rs.h file

Summary

In D5480 we hardcoded a path to this that ended up changing in a later version of React Native. This diff updates the code so the path is passed directly from corrosion-cxx.cmake to where it's consumed.

Test Plan

I tested an Android debug build on both current master and my React Native upgrade branch and it worked

Diff Detail

Repository

rCOMM Comm

Branch

ashoat/cmake_android

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Nov 10 2022, 12:41 PM

Herald added subscribers: • abosh, atul, tomek. · View Herald TranscriptNov 10 2022, 12:41 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Nov 10 2022, 12:42 PM

Harbormaster failed remote builds in B13376: Diff 18338!

Address CMake Lint

Harbormaster completed remote builds in B13378: Diff 18347.Nov 10 2022, 1:29 PM

ashoat requested review of this revision.Nov 10 2022, 1:29 PM

varun accepted this revision.Nov 10 2022, 1:32 PM

This revision is now accepted and ready to land.Nov 10 2022, 1:32 PM

Closed by commit rCOMMf7a17e3c25fa: [native] Avoid hardcoding path to rust_native_library lib.rs.h file (authored by ashoat). · Explain WhyNov 10 2022, 1:39 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMMf7a17e3c25fa: [native] Avoid hardcoding path to rust_native_library lib.rs.h file.

Revision Contents
Changeset List

Path

Size

native/

android/

app/

CMakeLists.txt

2 lines

shared/

cmake/

corrosion-cxx.cmake

15 lines

Diff 18347

View Options

native/android/app/CMakeLists.txt