Paths

Table of Contentst

Differential D5599

[web] Add spoiler style to MarkdownSpoiler
ClosedPublic
Actions

Authored by rohan on Nov 10 2022, 9:56 AM.

Tags

None

Referenced Files

	F3391505: D5599.diff
	Sat, Nov 30, 4:21 AM

	Unknown Object (File)
	Wed, Nov 27, 4:40 AM

	Unknown Object (File)
	Wed, Nov 27, 3:58 AM

	Unknown Object (File)
	Wed, Nov 27, 3:38 AM

	Unknown Object (File)
	Sun, Nov 24, 12:12 AM

	Unknown Object (File)
	Oct 27 2024, 2:20 PM

	Unknown Object (File)
	Oct 27 2024, 2:20 PM

	Unknown Object (File)
	Oct 27 2024, 2:20 PM

Subscribers

Details

Reviewers

atul
ginsu

Commits

rCOMM343181cad8b6: [web] Add spoiler style to MarkdownSpoiler

Summary

We add a unique spoiler style (the same hex code as approved in D5373) to the MarkdownSpoiler component.

https://linear.app/comm/issue/ENG-2191/add-spoiler-style-to-markdowncss

Depends on D5593

Test Plan

The spoiler text enclosed in || ... || characters are correctly rendered with the new spoiler style visually and in the inspect element console.

Spoiler Style.png (1×1 px, 381 KB)

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

rohan created this revision.Nov 10 2022, 9:56 AM

Herald added subscribers: • abosh, tomek, ashoat. · View Herald TranscriptNov 10 2022, 9:56 AM

rohan edited the summary of this revision. (Show Details)Nov 10 2022, 9:57 AM

rohan edited the test plan for this revision. (Show Details)

rohan added a parent revision: D5593: [web] Extract thread-related selectors out of web/selectors/nav-selectors.

rohan attached a referenced file: F231808: Spoiler Style.png. (Show Details)

Harbormaster completed remote builds in B13369: Diff 18331.Nov 10 2022, 10:10 AM

rohan requested review of this revision.Nov 10 2022, 10:10 AM

rohan edited the summary of this revision. (Show Details)Nov 10 2022, 10:33 AM

rohan added a child revision: D5601: [web] Reveal the spoiler content on click within a message.

Rebase on MarkdownSpoiler changes

Harbormaster completed remote builds in B13388: Diff 18363.Nov 10 2022, 5:47 PM

ginsu accepted this revision.Nov 11 2022, 9:17 AM

Move spoiler styles below markdown anchor tags

Harbormaster completed remote builds in B13410: Diff 18394.Nov 11 2022, 5:14 PM

Looks good, we just need to pull the hardcoded hex values out and move them to web/theme.css

web/markdown/markdown.css
80–84 ↗	(On Diff #18394)	On `web` we try to avoid hardcoding hex values and instead create CSS variables in `web/theme.css` to consume throughout. This should be good to land once you pull out the constants to `web/theme.css` and use them here instead.

This revision now requires changes to proceed.Nov 14 2022, 5:06 PM

atul mentioned this in D5601: [web] Reveal the spoiler content on click within a message.Nov 14 2022, 5:12 PM

Use CSS Variables in theme.css

Harbormaster completed remote builds in B13434: Diff 18428.Nov 15 2022, 6:16 AM

Perfect!

This revision is now accepted and ready to land.Nov 15 2022, 3:40 PM

Closed by commit rCOMM343181cad8b6: [web] Add spoiler style to MarkdownSpoiler (authored by rohan). · Explain WhyNov 16 2022, 9:06 AM

This revision was automatically updated to reflect the committed changes.

rohan added a commit: rCOMM343181cad8b6: [web] Add spoiler style to MarkdownSpoiler.

Revision Contents
Changeset List

Path

Size

web/

markdown/

markdown-spoiler.react.js

4 lines

6 lines

2 lines

Diff 18428

web/markdown/markdown-spoiler.react.js

Loading...

web/markdown/markdown.css

Loading...

web/theme.css

Loading...