[web] Add spoiler rule to simpleMarkdownRules
ClosedPublic
Actions

Authored by rohan on Nov 7 2022, 11:40 AM.

Details

Reviewers

atul
ginsu

Commits

rCOMM52e40abceb1c: [web] Add spoiler rule to simpleMarkdownRules

Summary

We add the rule to web/markdown/rules.react.js in order to parse content enclosed within the || ... || characters to be spoilers. This is the web implementation of the spoiler feature.

Linear: https://linear.app/comm/issue/ENG-2190/add-spoiler-rule-to-simplemarkdownrules-in-webmarkdownrulesreactjs

Test Plan

Looked at the output in the inspect element tab on a specific message that has spoiler content. For now, until the next diff, the spoiler content is enclosed within span tags, signifying that the spoiler parse rule is working.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

rohan created this revision.Nov 7 2022, 11:40 AM

Herald added subscribers: • abosh, tomek, ashoat. · View Herald TranscriptNov 7 2022, 11:40 AM

rohan edited the summary of this revision. (Show Details)Nov 7 2022, 11:41 AM

rohan edited the test plan for this revision. (Show Details)

rohan attached a referenced file: F226270: Spoiler Rule.png. (Show Details)

Harbormaster completed remote builds in B13232: Diff 18159.Nov 7 2022, 11:57 AM

rohan requested review of this revision.Nov 7 2022, 11:57 AM

rohan added a child revision: D5553: [web] Create a MarkdownSpoiler component for the web implementation to render when parsed.Nov 7 2022, 6:13 PM

Looks like it matches D5347 (would've been helpful to link since the changes to native/markdown/rules.react.js haven't been landed in the repo)

This revision is now accepted and ready to land.Nov 8 2022, 7:14 AM

In D5546#164711, @atul wrote:

Looks like it matches D5347 (would've been helpful to link since the changes to native/markdown/rules.react.js haven't been landed in the repo)

Makes sense, thanks for the heads up

Closed by commit rCOMM52e40abceb1c: [web] Add spoiler rule to simpleMarkdownRules (authored by rohan). · Explain WhyNov 16 2022, 9:01 AM

This revision was automatically updated to reflect the committed changes.

rohan added a commit: rCOMM52e40abceb1c: [web] Add spoiler rule to simpleMarkdownRules.