Page MenuHomePhabricator
Differential D5623

[web] Make spoiler components block link reveal / click until the spoiler is revealed
ClosedPublic
Actions

Authored by rohan on Nov 12 2022, 11:39 AM.
Tags
None
Referenced Files
F3356301: D5623.id18489.diff
Sat, Nov 23, 6:04 PM
Unknown Object (File)
Mon, Nov 18, 5:14 AM
Unknown Object (File)
Tue, Nov 12, 2:38 PM
Unknown Object (File)
Tue, Nov 12, 10:52 AM
Unknown Object (File)
Sun, Oct 27, 2:16 PM
Unknown Object (File)
Oct 15 2024, 6:35 PM
Unknown Object (File)
Sep 30 2024, 2:43 AM
Unknown Object (File)
Sep 27 2024, 7:22 PM
View All 77 Files
Subscribers
• abosh
ashoat
tomek

Details

Reviewers
atul
ginsu
Commits
rCOMM628851dfb80e: [web] Make spoiler components block link reveal / click until the spoiler is…
Summary

We prevent links from being visible / clickable until the spoiler is clicked and revealed.

Depends on D5617

Test Plan

Run yarn dev in keyserver and web with these new changes and confirm the links are not clickable until spoilers are revealed.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

rohan created this revision.Nov 12 2022, 11:39 AM
Herald added subscribers: • abosh, tomek, ashoat. · View Herald TranscriptNov 12 2022, 11:39 AM
rohan edited the summary of this revision. (Show Details)Nov 12 2022, 11:40 AM
rohan edited the test plan for this revision. (Show Details)
rohan added a parent revision: D5617: [web] Prevent hidden spoiler content from being revealed by text/cursor highlighting.
rohan attached a referenced file: F236364: Spoiler Links.mov. (Show Details)Nov 12 2022, 11:45 AM
Harbormaster completed remote builds in B13414: Diff 18398.Nov 12 2022, 11:53 AM
rohan requested review of this revision.Nov 12 2022, 11:53 AM
ashoat added a comment.Nov 13 2022, 6:51 AM

To clarify – when you click the first time, it reveals the spoiler, but doesn't open the lik until you click a second time?

rohan added a comment.Nov 14 2022, 10:23 AM
In D5623#166620, @ashoat wrote:

To clarify – when you click the first time, it reveals the spoiler, but doesn't open the lik until you click a second time?

Yeah exactly. This is the before behavior:

rohan attached a referenced file: F240726: Prior.mov. (Show Details)Nov 14 2022, 10:23 AM
ashoat added a comment.Nov 14 2022, 11:31 AM

Nice!!

atul requested changes to this revision.Nov 14 2022, 5:16 PM

Super close! Just move the hex value to web/theme.css and this'll be good to land

web/markdown/markdown.css
92 ↗(On Diff #18398)

Let's move this out to CSS variable in web/theme.css and consume here.

This revision now requires changes to proceed.Nov 14 2022, 5:16 PM
rohan updated this revision to Diff 18435.Nov 15 2022, 8:16 AM

Use CSS Variables

Harbormaster completed remote builds in B13437: Diff 18435.Nov 15 2022, 8:30 AM
atul accepted this revision.Nov 15 2022, 3:51 PM

Sweet!

This revision is now accepted and ready to land.Nov 15 2022, 3:51 PM
Closed by commit rCOMM628851dfb80e: [web] Make spoiler components block link reveal / click until the spoiler is… (authored by rohan). · Explain WhyNov 16 2022, 9:15 AM
This revision was automatically updated to reflect the committed changes.
rohan added a commit: rCOMM628851dfb80e: [web] Make spoiler components block link reveal / click until the spoiler is….

Revision Contents
Changeset List

PathSize
web/
markdown/
4 lines

Diff 18435

View Options

web/markdown/markdown.css

Loading...