[Android] Use shared proto cmake project
AbandonedPublicDraft
Actions

Authored by • jon on Nov 18 2022, 2:09 PM.

Details

Reviewers

atul
varun
tomek
• max

Summary

Use cmake project from shared/protos directory. This is
an initial step in removing GLOB RECURSE usage in app/CMakeLists.txt.

This is to show that the cmake logic from native/cpp and shared/protos
can be used in the android build.

Part of https://linear.app/comm/issue/ENG-776

Depends on D5686

Test Plan

Android gate passes

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• jon created this revision.Nov 18 2022, 2:09 PM

Herald added a subscriber: ashoat. · View Herald TranscriptNov 18 2022, 2:09 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Nov 18 2022, 2:10 PM

Harbormaster failed remote builds in B13579: Diff 18599!

Rebase

Harbormaster returned this revision to the author for changes because remote builds failed.Nov 18 2022, 2:26 PM

Harbormaster failed remote builds in B13581: Diff 18602!

Ensure protos/CMakeLists.txt doesn't require grpc

Harbormaster returned this revision to the author for changes because remote builds failed.Nov 18 2022, 2:52 PM

Harbormaster failed remote builds in B13584: Diff 18605!

Rebase on changes

Harbormaster returned this revision to the author for changes because remote builds failed.Nov 28 2022, 10:19 AM

Harbormaster failed remote builds in B13799: Diff 18890!

Should we abandon this now that gRPC-C++ isn't used from the Android build following D5706?

Should we abandon this now that gRPC-C++ isn't used from the Android build following D5706?

Note, the tunnelbroker build is now building against protobuf 3.12

• jon abandoned this revision.Nov 30 2022, 7:17 PM

Revision Contents
Changeset List

Path

Size

native/

android/

app/

CMakeLists.txt

10 lines

shared/

protos/

CMakeLists.txt

4 lines

Diff 18605

View Options

native/android/app/CMakeLists.txt