we removed the public key from users/sessions table, i was under the impression every new account was registering with the public key from their device

public key isn't getting used yet:

We need this for SIWE because the "social proof" should have this key, and it's easier for us to make sure it's there from the start then to go back and have to rethink things later

^link

added the diff to the stack (i wrote depends on [link] instead of depends on [diff#]) - regarding single eth address, i'm confident that's covered in D5603, but there's definitely more work to be done in that category (making sure normal usernames don't overlap, ens resolution etc.)

it's really a placeholder pending more discussion on what the social proof actually consists of. i removed it and marked it as optional in the flow types. i'll add a comment to the linear task linking back to this diff

reran codegen but no changes came up - i think it was just the lack of typing on js side

Why'd you remove this space

Prefix with + to make $ReadOnly

Yes you cannot use TypeScript declarations in Flow...

You have to type WebViewProps in Flow.

if not, how do I typecast WebViewProps as a component?

You shouldn't be "typecasting" it, you should just make sure you're using the types correctly.

Have you tried Googling eg. "how to type a React component in Flow"? The first result for that query (for me, anyways) is Flow's React type reference. You could start by reading React.Ref first (since that's what you're using here), and next try reading React.ComponentType.

What's obviously wrong here from a cursory read through those docs is that you're passing a type representing the props of a component (WebViewProps) to a type (React.Ref) that expects its parameter to be a React component (React.ComponentType).

We need to verify that request.address actually signed the socialProof

I checked the whitepaper draft for what to use. Here's what I found:

Comm wants you to sign in with your Ethereum account:
0xC02aaA39b223FE8D0A0e5C4F27eAD9083C756Cc2
I accept the Comm Terms of Service: https://comm.app/tos
URI: https://comm.app/login
Version: 1
Chain ID: 1
Nonce: 32891756
Issued At: 2022-07-24T16:25:24Z

There's a lot of questions here:

1. I think it's missing the public key. I'm rather confident that's an accidental omission, but currently checking with Anunay. You're including that here which is good!
2. We need a nonce passed in from the keyserver I think, but I seem to remember there's a task for that?
3. I can't tell what part of this is SIWE boilerplate (presumably that this SiweMessage class will handle?), and it's confusing to see the developer-defined message split by the Ethereum address.
4. We should probably update the whitepaper to have the real "URI" produced by our messages in production instead of "https://comm.app/login"
5. "https://comm.app/tos" in the whitepaper should be replaced with "https://comm.app/terms"

We can probably handle all of this stuff in a later diff