Page MenuHomePhabricator

Fix draft store operations
ClosedPublic

Authored by marcin on Nov 28 2022, 4:47 AM.
Tags
None
Referenced Files
F6238770: D5731.diff
Thu, Apr 24, 6:48 PM
Unknown Object (File)
Fri, Apr 11, 6:14 AM
Unknown Object (File)
Fri, Mar 28, 7:02 PM
Unknown Object (File)
Mar 16 2025, 10:05 AM
Unknown Object (File)
Mar 16 2025, 10:05 AM
Unknown Object (File)
Mar 16 2025, 9:54 AM
Unknown Object (File)
Mar 16 2025, 9:41 AM
Unknown Object (File)
Mar 7 2025, 4:49 PM
Subscribers

Details

Summary

Current implementation of draft store operations creation and processing does not obey new policy regarding cancellable asynchronous tasks and tries to access 'payload' property of draft store operation object even if the operation is of type 'remove_all' and does not contain this property. This results in app crashes when logging out.

Test Plan

Build native app on top of https://phab.comm.dev/D5712. Log out - see that app crashes. Apply this differential. See that application does not crash and succesfully logs out.

Diff Detail

Repository
rCOMM Comm
Branch
marcin/fix-draft-store-operations
Lint
No Lint Coverage
Unit
No Test Coverage