Paths

Table of Contentst

Differential D5771

Refactor getAllDrafts. Bring db drafts parsing to separate function
ClosedPublic
Actions

Authored by marcin on Nov 30 2022, 10:34 AM.

Tags

None

Referenced Files

	F3500681: D5771.id19094.diff
	Fri, Dec 20, 2:12 AM

	F3499465: D5771.id19018.diff
	Thu, Dec 19, 11:12 PM

	F3497988: D5771.diff
	Thu, Dec 19, 8:28 PM

	Unknown Object (File)
	Fri, Nov 22, 6:45 AM

	Unknown Object (File)
	Fri, Nov 22, 6:45 AM

	Unknown Object (File)
	Fri, Nov 22, 6:45 AM

	Unknown Object (File)
	Fri, Nov 22, 6:45 AM

	Unknown Object (File)
	Fri, Nov 22, 6:39 AM

Subscribers

Details

Reviewers

tomek
atul
• jon

Commits

rCOMM50428a1a22c2: Refactor getAllDrafts. Bring db drafts parsing to separate function

Summary

This differential refactors getAllDrafts method so that draft parsing is implemented in separate function. This is going to be used when creating bulk JSI query for all SQLite data

Test Plan

Launch the app, write some drafts, kill the app. Launch the app, launch Flipper ensure SET_CLIENT_DB_STORE action payload has corract drafts property.

Diff Detail

Repository

Branch

marcin/eng-2137

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

marcin created this revision.Nov 30 2022, 10:34 AM

Herald added a reviewer: • jon. · View Herald TranscriptNov 30 2022, 10:34 AM

Herald added a subscriber: ashoat. · View Herald Transcript

marcin added a child revision: D5772: Refactor getAllMessages{Sync}. Bring db messages parsing to separate function.Nov 30 2022, 10:43 AM

Harbormaster completed remote builds in B13885: Diff 19018.Nov 30 2022, 10:47 AM

marcin requested review of this revision.Nov 30 2022, 10:47 AM

tomek accepted this revision.Dec 1 2022, 4:50 AM

This revision is now accepted and ready to land.Dec 1 2022, 4:50 AM

Rebase before landing

Harbormaster completed remote builds in B13934: Diff 19094.Dec 2 2022, 12:55 AM

Closed by commit rCOMM50428a1a22c2: Refactor getAllDrafts. Bring db drafts parsing to separate function (authored by marcin). · Explain WhyDec 2 2022, 1:06 AM

This revision was automatically updated to reflect the committed changes.

marcin added a commit: rCOMM50428a1a22c2: Refactor getAllDrafts. Bring db drafts parsing to separate function.

Revision Contents
Changeset List

Path

Size

native/

cpp/

CommonCpp/

NativeModules/

CommCoreModule.cpp

57 lines

Diff 19018

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp

Loading...