Paths

Table of Contentst

-
native/chat/
-
chat/
-
text-message-markdown-context.js

Differential D5779

[native] Add spoiler to pressableMarkdownTypes
ClosedPublic
Actions

Authored by rohan on Nov 30 2022, 2:01 PM.

Tags

None

Referenced Files

	F5107560: D5779.diff
	Tue, Apr 1, 11:36 AM

	Unknown Object (File)
	Fri, Mar 28, 4:27 PM

	Unknown Object (File)
	Wed, Mar 26, 6:56 AM

	Unknown Object (File)
	Tue, Mar 25, 3:55 PM

	Unknown Object (File)
	Mon, Mar 17, 3:57 AM

	Unknown Object (File)
	Mon, Mar 17, 3:52 AM

	Unknown Object (File)
	Fri, Mar 14, 7:36 PM

	Unknown Object (File)
	Thu, Mar 6, 4:45 PM

View All 96 Files

Subscribers

Details

Reviewers

ashoat
atul
ginsu

Commits

rCOMM8134e800efff: [native] Add spoiler to pressableMarkdownTypes

Summary

Following the stack from @ashoat, we now add spoiler to the pressableMarkdownTypes set.

Depends on D5539

Test Plan

Check spoilers on both Android and iOS, will attach a video below.

Diff Detail

Repository

Branch

spoiler (branched from rohan/native-spoilers)

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

rohan created this revision.Nov 30 2022, 2:01 PM

Herald added a subscriber: tomek. · View Herald TranscriptNov 30 2022, 2:01 PM

rohan edited the summary of this revision. (Show Details)Nov 30 2022, 2:02 PM

rohan edited the test plan for this revision. (Show Details)

rohan edited the summary of this revision. (Show Details)

rohan added a parent revision: D5539: [native] Maintain the revealed state of spoilers.

rohan attached a referenced file: F267394: Screen Recording 2022-11-30 at 4.58.53 PM.mov. (Show Details)

Harbormaster completed remote builds in B13898: Diff 19043.Nov 30 2022, 2:13 PM

rohan requested review of this revision.Nov 30 2022, 2:13 PM

ashoat accepted this revision.Nov 30 2022, 2:16 PM

This revision is now accepted and ready to land.Nov 30 2022, 2:16 PM

Closed by commit rCOMM8134e800efff: [native] Add spoiler to pressableMarkdownTypes (authored by rohan). · Explain WhyNov 30 2022, 3:49 PM

This revision was automatically updated to reflect the committed changes.

rohan added a commit: rCOMM8134e800efff: [native] Add spoiler to pressableMarkdownTypes.

Revision Contents
Changeset List

Path

Size

native/

chat/

text-message-markdown-context.js

2 lines

Diff 19043

native/chat/text-message-markdown-context.js

	Show First 20 Lines • Show All 98 Lines • ▼ Show 20 Lines

	export type FFmpegStatistics = {			export type FFmpegStatistics = {
	// seconds of video being processed per second			// seconds of video being processed per second
	+speed: number,			+speed: number,
	// total milliseconds of video processed so far			// total milliseconds of video processed so far
	+time: number,			+time: number,
	// total result file size in bytes so far			// total result file size in bytes so far
	+size: number,			+size: number,
	+videoQuality: number,
	+videoFrameNumber: number,
	+videoFps: number,
	+bitrate: number,
	};			};

	export type TranscodeVideoMediaMissionStep = {			export type TranscodeVideoMediaMissionStep = {
	+step: 'video_ffmpeg_transcode',			+step: 'video_ffmpeg_transcode',
	+success: boolean,			+success: boolean,
	+exceptionMessage: ?string,			+exceptionMessage: ?string,
	+time: number, // ms			+time: number, // ms
	+returnCode: ?number,
	+newPath: ?string,			+newPath: ?string,
	+stats: ?FFmpegStatistics,			+stats: ?FFmpegStatistics,
	};			};

	export type VideoGenerateThumbnailMediaMissionStep = {			export type VideoGenerateThumbnailMediaMissionStep = {
	+step: 'video_generate_thumbnail',			+step: 'video_generate_thumbnail',
	+success: boolean,			+success: boolean,
	+time: number, // ms			+time: number, // ms
	▲ Show 20 Lines • Show All 698 Lines • Show Last 20 Lines