Differential D5756

[Fix] Swapped deprecated keyCode to key.
ClosedPublic
Actions

Authored by • przemek on Nov 29 2022, 8:52 AM.

Tags

None

Referenced Files

	F2904247: D5756.id19063.diff
	Sun, Oct 6, 12:48 AM

	F2904237: D5756.id19064.diff
	Sun, Oct 6, 12:45 AM

	Unknown Object (File)
	Thu, Sep 26, 6:15 AM

	Unknown Object (File)
	Thu, Sep 19, 11:13 PM

	Unknown Object (File)
	Thu, Sep 19, 11:13 PM

	Unknown Object (File)
	Thu, Sep 19, 11:13 PM

	Unknown Object (File)
	Thu, Sep 19, 11:13 PM

	Unknown Object (File)
	Thu, Sep 19, 11:11 PM

View All 90 Files

Subscribers

Details

Reviewers

tomek
kamil
atul

Commits

rCOMMe47747b8327d: [Fix] Swapped deprecated keyCode to key.

Summary

Swapped keyCodes to keys and changed values accordingly. We shouldn't allow keyCode to be added to codebase anymore.
Fixing: https://linear.app/comm/issue/ENG-2212/keyboardeventkeycode-is-deprecated-we-should-use-key-instead

Test Plan

Chat input - sends message on enter
Color picker - I think we're actually using ColorSelector and this file is not used anywhere,
shoudl I create issue to delete it?
Modal overlay - modals still close on escape,
Calendar entry - blurs on escape,
Multimedia overaly - closes on escape,

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• przemek created this revision.Nov 29 2022, 8:52 AM

Herald added a subscriber: ashoat. · View Herald TranscriptNov 29 2022, 8:52 AM

• przemek added 1 blocking reviewer(s): tomek.Nov 29 2022, 8:55 AM

Harbormaster completed remote builds in B13845: Diff 18963.Nov 29 2022, 9:04 AM

• przemek requested review of this revision.Nov 29 2022, 9:04 AM

tomek accepted this revision.Nov 30 2022, 4:47 AM

tomek added inline comments.

web/modals/threads/color-picker.react.js
61 ↗	(On Diff #18963)	This comment can be deleted now

This revision is now accepted and ready to land.Nov 30 2022, 4:47 AM

deleted comment

Harbormaster completed remote builds in B13910: Diff 19063.Dec 1 2022, 2:18 AM

Closed by commit rCOMMe47747b8327d: [Fix] Swapped deprecated keyCode to key. (authored by • przemek). · Explain WhyDec 1 2022, 2:44 AM

This revision was automatically updated to reflect the committed changes.

• przemek added a commit: rCOMMe47747b8327d: [Fix] Swapped deprecated keyCode to key..

Revision Contents
Changeset List

Path

Size

lib/

components/

modal-overlay.react.js

2 lines

web/

calendar/

2 lines

chat/

chat-input-bar.react.js

2 lines

media/

multimedia-modal.react.js

2 lines

modals/

threads/

color-picker.react.js

3 lines

Diff 19064

lib/components/modal-overlay.react.js

Loading...

web/calendar/entry.react.js

Loading...

web/chat/chat-input-bar.react.js

Loading...

web/media/multimedia-modal.react.js

Loading...

web/modals/threads/color-picker.react.js

Loading...